New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to filter files by wildcard, eg "*.jpg" #56

Closed
mherrmann opened this Issue Mar 21, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@mherrmann
Contributor

mherrmann commented Mar 21, 2017

No description provided.

@fman-issues-bot fman-issues-bot bot added the 2 votes label May 15, 2017

@fman-issues-bot fman-issues-bot bot added 3 votes and removed 2 votes labels Jun 20, 2017

@fman-issues-bot fman-issues-bot bot added 4 votes and removed 3 votes labels Oct 21, 2017

@fman-issues-bot fman-issues-bot bot added 5 votes and removed 4 votes labels Nov 29, 2017

@fman-issues-bot fman-issues-bot bot added 6 votes and removed 5 votes labels Feb 21, 2018

@fman-issues-bot fman-issues-bot bot added 7 votes and removed 6 votes labels Mar 5, 2018

@fman-issues-bot fman-issues-bot bot added 8 votes and removed 7 votes labels Mar 15, 2018

@oskretc

This comment has been minimized.

oskretc commented Apr 9, 2018

+1

@fman-issues-bot fman-issues-bot bot added 9 votes and removed 8 votes labels May 11, 2018

@fman-issues-bot fman-issues-bot bot added 10 votes and removed 9 votes labels May 27, 2018

@fman-issues-bot fman-issues-bot bot added 11 votes and removed 10 votes labels Jun 10, 2018

@fman-issues-bot fman-issues-bot bot added 14 votes and removed 13 votes labels Aug 8, 2018

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Sep 12, 2018

Implemented in fman 1.3.1. 🎉

@mherrmann mherrmann closed this Sep 12, 2018

@mherrmann mherrmann removed the in progress label Sep 12, 2018

@keith-hall

This comment has been minimized.

keith-hall commented Sep 25, 2018

Is this new filtering functionality exposed in the API at all? I had a quick look but couldn't find it anywhere. I'd like to be able to filter by multiple wildcards, e.g. *.jpg|*.png and have a plugin that would allow me to quickly use predefined filters for all "picture files" etc. Also, if it were part of the API, #73 could be implemented by a plugin.

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Sep 25, 2018

It's currently not part of the API. For a discussion, please see here.

@mherrmann

This comment has been minimized.

Contributor

mherrmann commented Sep 25, 2018

To be more precise regarding your specific question: I hope the current DirectoryPane#_add_filter(...) mentioned in the comment could be made part of the public API and let you do what you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment