Make it possible to send any argument to the connect method when using SingleServerIRCBot #1

Merged
merged 2 commits into from Dec 1, 2011

Conversation

Projects
None yet
2 participants
@WizKid

WizKid commented Nov 30, 2011

No description provided.

Generalise the arguments to SingleServerIRCBot so if connection argum…
…ents are added further down SingleServerIRCBot don't have to be updated
@fmoo

This comment has been minimized.

Show comment Hide comment
@fmoo

fmoo Dec 1, 2011

I've recently become of a fan of the
dict(foo=bar) style of dictionaries than the {'foo': bar}

Either way works for me. Just wondering if you knew if there was any particular benefit to doing it one way vs. the other.

I've recently become of a fan of the
dict(foo=bar) style of dictionaries than the {'foo': bar}

Either way works for me. Just wondering if you knew if there was any particular benefit to doing it one way vs. the other.

This comment has been minimized.

Show comment Hide comment
@WizKid

WizKid Dec 1, 2011

Owner

I just like {'foo': bar} more. Less to type :)

Owner

WizKid replied Dec 1, 2011

I just like {'foo': bar} more. Less to type :)

@fmoo

This comment has been minimized.

Show comment Hide comment
@fmoo

fmoo Dec 1, 2011

we should probably bump minor version in irclib.py to 0, 5, 0 since this is a breaking change.

fmoo commented on db3e86b Dec 1, 2011

we should probably bump minor version in irclib.py to 0, 5, 0 since this is a breaking change.

@WizKid

This comment has been minimized.

Show comment Hide comment
@WizKid

WizKid Dec 1, 2011

These where the only places I found 0.4.8

WizKid commented Dec 1, 2011

These where the only places I found 0.4.8

fmoo added a commit that referenced this pull request Dec 1, 2011

Merge pull request #1 from WizKid/master
Consolidate SingleServerIRCBot constructor args.

Also, bump to 0.5.0 since this breaks API.

@fmoo fmoo merged commit 7b137c6 into fmoo:master Dec 1, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment