Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormatTest.StrError fails on Solaris #1213

Closed
vedranmiletic opened this issue Jul 1, 2019 · 1 comment · Fixed by #1217
Closed

FormatTest.StrError fails on Solaris #1213

vedranmiletic opened this issue Jul 1, 2019 · 1 comment · Fixed by #1217

Comments

@vedranmiletic
Copy link

@vedranmiletic vedranmiletic commented Jul 1, 2019

OpenIndiana Hipster 2019.04 just like in #1203, GCC 8.3.0, fmt revision 2711cb1 compiling nicely now (thanks!). However, when running tests I get:

[----------] 5 tests from FormatTest
[ RUN      ] FormatTest.ArgConverter
[       OK ] FormatTest.ArgConverter (0 ms)
[ RUN      ] FormatTest.FormatNegativeNaN
[       OK ] FormatTest.FormatNegativeNaN (0 ms)
[ RUN      ] FormatTest.StrError
test/format-impl-test.cc:202: Failure
Value of: message
  Actual: "Argument out of domain"
Expected: ""
[  FAILED  ] FormatTest.StrError (1 ms)
[ RUN      ] FormatTest.FormatErrorCode
[       OK ] FormatTest.FormatErrorCode (0 ms)
[ RUN      ] FormatTest.CountCodePoints
[       OK ] FormatTest.CountCodePoints (0 ms)
[----------] 5 tests from FormatTest (1 ms total)

[----------] Global test environment tear-down
[==========] 17 tests from 3 test cases ran. (3 ms total)
[  PASSED  ] 16 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] FormatTest.StrError
@vitaut

This comment has been minimized.

Copy link
Contributor

@vitaut vitaut commented Jul 2, 2019

Looks like strerror* on OpenIndiana Hipster has the same issue as MinGW. The workaround is to change

#ifndef __MINGW32__

to

#if !defined(__MINGW32__) && !defined(...) // <- put some macro to detect your system here

in

#ifndef __MINGW32__

Could you submit a PR since you are in the best position to check that it works?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.