Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for some pedantic warnings #1054

Merged
merged 5 commits into from Feb 23, 2019
Merged

Fixes for some pedantic warnings #1054

merged 5 commits into from Feb 23, 2019

Conversation

@ricco19
Copy link
Contributor

ricco19 commented Feb 23, 2019

Some small changes required for me to compile with stricter compiler flags

@@ -62,6 +62,10 @@
#if FMT_GCC_VERSION >= 406 || FMT_CLANG_VERSION
# pragma GCC diagnostic push

// Disable warning about not handling all enums in switch statement even with
// a default case
# pragma GCC diagnostic ignored "-Wswitch-enum"

This comment has been minimized.

Copy link
@vitaut

vitaut Feb 23, 2019

Contributor

Could you post specific warnings this is causing? Might be better to fix those instead of suppressing.

This comment has been minimized.

Copy link
@ricco19

ricco19 Feb 23, 2019

Author Contributor

screenshot_2019-02-23_13-29-00

I thought having a default case is cleaner and just disabling this warning is preferable.

include/fmt/format.h Outdated Show resolved Hide resolved
@vitaut

This comment has been minimized.

Copy link
Contributor

vitaut commented Feb 23, 2019

Thanks for the PR! Just two minor inline comments.

@vitaut vitaut merged commit 327d4b6 into fmtlib:master Feb 23, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vitaut

This comment has been minimized.

Copy link
Contributor

vitaut commented Feb 23, 2019

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.