Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a compile error under MSVC (#1143). #1144

Merged
merged 1 commit into from May 5, 2019
Merged

Conversation

@rcane
Copy link
Contributor

rcane commented May 5, 2019

See #1143.

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

The #warning directive is not supported by MSVC.
To still get a message to the user we use #pragma message() under MSVC now.
@vitaut vitaut merged commit ca7c1f8 into fmtlib:master May 5, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vitaut

This comment has been minimized.

Copy link
Contributor

vitaut commented May 5, 2019

Thanks!

@rcane rcane deleted the rcane:msvc-compile-fix branch May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.