New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement collection diff updates #12

Merged
merged 6 commits into from Feb 5, 2017
Next

Add diff case for val->nil change

  • Loading branch information...
nblumoe committed Jan 19, 2017
commit b4cb5129858a54494f8057cf6ba9858d87d24ab7
Copy path View file
@@ -119,7 +119,9 @@
(do (delete-component! dom (:dom-node a))
(diff dom nil b)))
[:comp :nil] (->Deleted (:dom-node a))))
[:comp :nil] (->Deleted (:dom-node a))
[:val :nil] (->Deleted a)))
(defn component
Copy path View file
@@ -92,6 +92,10 @@
[:set-property 1 :root 2]]}))))
)
(testing "from value to nil"
(let [log (log)
value :x]
(is (= (->Deleted value) (diff log value nil))))))
(deftest component-diffing
(testing "can change spec values"
ProTip! Use n and p to navigate between commits in a pull request.