Skip to content
This repository

selectmenu rendering changes when using ui-darkness #197

Closed
oleersoy opened this Issue November 30, 2011 · 20 comments

2 participants

Ole Ersoy Felix Nagel
Ole Ersoy

If I change the css import in the demo from the current one to this:

<link   rel="stylesheet"
        type="text/css" 
        href="http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.16/themes/ui-darkness/jquery-ui.css"/>

The demo no longer displays right. I tried finding a newer version to test with in the trunk, but it seems only the default theme is provided...

Felix Nagel
Owner

Mhh works nice for me, see: http://jsfiddle.net/GXtpC/172/

Demo link?

Ole Ersoy

It looks good here too. I wonder if we are comparing apples to apples though. I believe the fiddle is using different versions of jquery and jquery ui. What I did was download the lastest 1.9 version you gave me earlier (Github). I then changed only the css import in the demo default.html, and the selectmenu essentially breaks.

Ole Ersoy

I tried to create a fiddle with every single resource from the selectmenu branch, but it's not running for some reason:
http://jsfiddle.net/gwLYv/

In the process I realized that the original default.html demo css import included the selectmenu.css file. When I replaced that import I neglected to include this file. I have since included it, and it's not as broken as I thought it was...but still not quite right.

What I'm seeing is the width of the drop down menu is the width of the longest item in the list. So for example in the selectmenu instance containing only numbers, the width of the drop down menu is the width of the biggest number.

Ole Ersoy

This is the css that I'm now importing in default.html:

<link   rel="stylesheet"
        type="text/css" 
        href="http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.16/themes/ui-darkness/jquery-ui.css"/>
<link   rel="stylesheet"
        type="text/css" 
        href="file:///home/ole/Desktop/jquery-jquery-ui-b539e2e/themes/base/jquery.ui.selectmenu.css"/>

Also - Did you look at the last two selectmenu instances in your fiddle?

Felix Nagel
Owner

Wait. What (which version of selectmenu) are we talking about?
My posted fiddle inlcudes THIS branch (the "old" version) and it works fine (even the last two selectmenus) with themeroller.

This branch is not compatible with UI 1.9.x and this issue is not for talking about the new, built from scratch version. Please comment on #140 for that kind of purposes.

In your fiddle you linked LOCAL files. How is this supposed to work?

Ive added a demo for TS, take a look here: jquery@c00b685

Ole Ersoy

Ooops - Sorry I'm trying learn Jquery, github, jsfiddle, etc. all at the same time and complete a project, so I'm a little more scattered than general.

I figured jsfiddle would recognize that the resource entered is a file URL, and upload the resource... apparently a bad assumption.

I see that the selectmenu works fine when using the themeswitcher tool. I'm not sure what I'm doing wrong. If I take the css import:

<link rel="stylesheet" href="../../../themes/base/jquery.ui.all.css">

and replace it with:

type="text/css"
href="http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.16/themes/ui-darkness/jquery-ui.css"/>
type="text/css"
href="file:///home/ole/Desktop/jquery-jquery-ui-c00b685/themes/base/jquery.ui.selectmenu.css"/>

The selectmenus don't display right....

Any ideas?

Felix Nagel
Owner
Ole Ersoy

Yes. I'm trying to run the default.html demo with the UI darkness theme. The above css links are from an experiment locally on my workstation. It looks to me like importing ui-darkness from the cdn alone is not enough. I therefore also imported the jquery.ui.selectmenu.css (From the built from scratch download). However the selectmenu instances still look off (drop down arrows are on the wrong side, etc.).

Felix Nagel
Owner
Ole Ersoy

Yes I can see how the widget does work when you are using the theme selector. It works for me too. However if I try to import the ui darkness theme via CDN into one of the demos, the display is off.

I'm using this version (The one with the visual theme switcher test in it - issue 140):
https://github.com/jquery/jquery-ui/tree/selectmenu

If you try replacing the generic css theme with the ui darkness theme directly, I imagine you will see the same issues.

I'll be glad to email you a copy of my modified default.html if that helps? I'm not sure how to create a fiddle since the release is not on CDN yet....

Felix Nagel
Owner

So you are using the unreleased dev version of selectmenu 2.0 which currently has some issues because of changes to Menu widget :-)

This branch (https://github.com/fnagel/jquery-ui/) should not be used for discussing selectmenu 2.0. Please use the jquery ui wiki, the jquery ui forum or the #140 issue.

Did you tried this file?
https://raw.github.com/jquery/jquery-ui/c00b685cb824fe940226be041067b0b9c44ba983/tests/visual/selectmenu/themeswitcher.html

That would work, just copy your file into a pastebin or send me an email with a zip: info @ felixnagel com

ps: you could link guthub files dircectly, see above (but CSS files wont work).

Ole Ersoy

Yes - see I have full trust in you :).

OK - got it - I'll keep 140 stuff in the 140 branch from now on. Here's a pastebin of what I'm talking about (140 Branch):

http://pastebin.com/tYZtxFLH

I took the themeswitcher.html file and commented out the jquery.ui.all.css and added the ui-darkness css from CDN. If you place this file in the same folder as the themeswitcher.html file and open it in a browser, all the selectmenu widgets will look off.

I did the same process on the default.html demo file in the "Stable" select menu branch:
https://github.com/fnagel/jquery-ui/

I used to have issues with this, but I just checked again with a fresh download, and now it's fine. Sweet!

If there's something you think I can help with on the 2.0 branch, please ask. My email is ole.ersoy @ gmail.com. Thanks.

Felix Nagel
Owner

You will need at least some files which will be included by the jquery.ui.all.css.

Try this one: http://pastebin.com/MGkyY1hP

There is a problem with the .ui-menu style in the themed CSS file. Its not ready yet for the new Menu widget. I added a small fix in the posted code.

Ole Ersoy
Felix Nagel
Owner

Sorry, ive posted the original file, not my modified one. -.-

Here you go: http://pastebin.com/1jNPuKLZ

Ole Ersoy
Felix Nagel
Owner

Puuhhh Konquerer is not on my list nor on the compatibility list of jQuery UI afaik ;-)
What rendering engine does it use? Does it fail when no custom theme is used?

I think this should be fixed when the themes are tested for jQuery UI 1.9.x. Its all dev atm.

Ole Ersoy
Felix Nagel
Owner

I added a notice (http://wiki.jqueryui.com/w/page/12138056/Selectmenu) and will check this when our development is finished so far.

Thanks for your contribution!

Felix Nagel fnagel closed this December 08, 2011
Ole Ersoy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.