eventPropagation for _toggle event #274

Closed
escapedcat opened this Issue Oct 15, 2012 · 5 comments

Projects

None yet

2 participants

@escapedcat

I'm using UIs datepicker and your selectmenu on the same page.

Problem was, that if I open the datepicker and click the selectmenu, the closing event for the datepicker isn't triggered, because the event is not bubbling up.

I tried to only exchange "return false" with "preventDefault", but than also the close event for the selectmenu is triggerd immediately after click to open it. I changed the binded event for closing the selectmenus to check the parent-id to avoid closing itself but keep bubble up and trigger other events (close datepicker i.e.).

Totally not sure if this a clean solution. Doesn't look like it, but at least I wanted to let you know and provide my solution.

This is a fiddle with my 'fix':
http://jsfiddle.net/escapedcat/GXtpC/722/

Also here is the diff with my changes:
escapedcat@690bbee

Owner
fnagel commented Oct 25, 2012

Problem confirmed. Fix seems to work nice.

Is this related to this problem? #238

Did you test this on different browsers?

Ah, yes... duplicate of that one.

I tested the fiddle in Chrome and Firebox (both latest). The IE9 has problems with the fiddle due to the script embedding of jsfiddle (I guess), but it's working fine in our project in Chrome/FF/IE9.

Owner
fnagel commented Nov 10, 2012

Merged and pushed. Thanks for your contribution.

@fnagel fnagel closed this Nov 10, 2012
@fnagel fnagel reopened this May 7, 2013
Owner
fnagel commented May 7, 2013

Hey @escapedcat would you mind checking this one out? #300 It seems its related to you fix. Any idea?

Owner
fnagel commented Sep 7, 2013

Closed as seems to be fixed.

@fnagel fnagel closed this Sep 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment