Fix for "focus doesn't bubble" & format option improvement #257

Merged
merged 2 commits into from Aug 30, 2012

Projects

None yet

2 participants

@aglemann

Less hacky fix for #241

Aeron Glemann added some commits Aug 10, 2012
Aeron Glemann fnagel#241
Updated jquery.simulate.js to latest
Fixed broken path in tests/jquery.js
Updated test to not use jquery.simulate for keypress (simulate was failing, not the test)
Fixed #241 in jquery.ui.selectmenu.js
Added the option object as optional parameter to formatText
3a751b7
Aeron Glemann Fixed formatting 4881ac4
@fnagel fnagel merged commit 16d8b73 into fnagel:selectmenu Aug 30, 2012
@fnagel
Owner

Sorry, for the late response. I was pretty busy the last few weeks (regular work and some festivals :-)

Afaics this pull request does include some other fixes too. Please send a pull request for each issue next time, thats much easier to handle.

Am I right that you additionally fixed one of these: #242, #199, #106
Seems these are solved with your patch, right? If so, this should be documented (note to myself, #224).

Your new patch works as nice as the last one. Thanks for your contribution, very appreciated!

ps: you can use '#' for issues and 'r' for revisions. Try to type 'm' (when not in a textfield) for some more formatting informion!

@aglemann

Yeah, seems like 242 and 199 are addressed with this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment