Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for "focus doesn't bubble" & format option improvement #257

Merged
merged 2 commits into from Aug 30, 2012

Conversation

Projects
None yet
2 participants

Less hacky fix for #241

Aeron Glemann added some commits Aug 10, 2012

#241
Updated jquery.simulate.js to latest
Fixed broken path in tests/jquery.js
Updated test to not use jquery.simulate for keypress (simulate was failing, not the test)
Fixed #241 in jquery.ui.selectmenu.js
Added the option object as optional parameter to formatText

fnagel added a commit that referenced this pull request Aug 30, 2012

Merge pull request #257 from aglemann/selectmenu
fixed: follow-up to #241, "focus" doesn't bubble, thx @aglemann

@fnagel fnagel merged commit 16d8b73 into fnagel:selectmenu Aug 30, 2012

Owner

fnagel commented Aug 30, 2012

Sorry, for the late response. I was pretty busy the last few weeks (regular work and some festivals :-)

Afaics this pull request does include some other fixes too. Please send a pull request for each issue next time, thats much easier to handle.

Am I right that you additionally fixed one of these: #242, #199, #106
Seems these are solved with your patch, right? If so, this should be documented (note to myself, #224).

Your new patch works as nice as the last one. Thanks for your contribution, very appreciated!

ps: you can use '#' for issues and 'r' for revisions. Try to type 'm' (when not in a textfield) for some more formatting informion!

Yeah, seems like 242 and 199 are addressed with this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment