Avoid class lookup collisions #6

Merged
merged 1 commit into from Apr 26, 2012

Projects

None yet

2 participants

@mhfs
Contributor
mhfs commented Mar 31, 2012

Always use global namespace to lookup models to avoid colliding with factory_girl-preload constants.

Cheers!

@mhfs
Contributor
mhfs commented Mar 31, 2012

Btw, I used Preload to make it obvious but collisions occur with any FG class. I noticed it with FactoryGirl::Declaration.

@mhfs
Contributor
mhfs commented Apr 26, 2012

@fnando sorry to bother but did you have the chance to look at this? Thanks.

@fnando fnando merged commit 762b66c into fnando:master Apr 26, 2012
@fnando
Owner
fnando commented Apr 26, 2012

Done. Thanks for your PR. ;)

@mhfs
Contributor
mhfs commented Apr 26, 2012

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment