Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full class name for rvm_environment resource usage inside Chef::Provider::Package:RVMRubygems class #284

Merged
merged 1 commit into from Jan 10, 2015
Merged

Use full class name for rvm_environment resource usage inside Chef::Provider::Package:RVMRubygems class #284

merged 1 commit into from Jan 10, 2015

Conversation

nomadium
Copy link

@nomadium nomadium commented Dec 8, 2014

I propose this change because the cookbook was not working with Chef 12.0.0. I also tested it with previous versions and works as expected.

This should fix: #283.

@akshah123
Copy link

👍 since it is a known deprecated functionality now. For refrence: chef/chef#2591

@martinisoft
Copy link
Contributor

Hiya @nomadium

Can you confirm if this change also breaks Chef 11 compatibility? I am fine with breaking Chef 10 at this point, but Chef 11 and 12 both should be supported until the 2.x release.

@nomadium
Copy link
Author

Hi @martinisoft.

I confirm you I tested this change with 11.16.4 and 12.0.0 and it worked.

@alambike
Copy link

alambike commented Jan 9, 2015

👍 Works ok in Chef 12.0.3

@mshappe
Copy link

mshappe commented Jan 10, 2015

👍 I just tested this by pulling the branch in via my Berksfile, and it seemed to behave much better, now! Someone ought to merge this! 😄

martinisoft added a commit that referenced this pull request Jan 10, 2015
…-incompatibility

Use full class name for rvm_environment resource usage inside Chef::Provider::Package:RVMRubygems class
@martinisoft martinisoft merged commit e840e57 into sous-chefs:master Jan 10, 2015
martinisoft added a commit that referenced this pull request Jan 10, 2015
@nomadium nomadium deleted the bug/rvm-rubygems-package-chef12-incompatibility branch January 11, 2015 01:50
@nimeshsubramanian
Copy link

@martinisoft and @cmluciano would love to see this released.

@ryancragun
Copy link

@martinisoft @cmluciano +1 for a release with this fix!

@tagomoris
Copy link

Are there any plan to release this fix?

@trinitronx
Copy link

It would seem that this fix is going to be incorporated into version 0.10.1 according to the CHANGELOG. If you are using Berkshelf to manage your cookbook dependencies, you can test out the unreleased new version by specifying a commit after #284 was merged in your Berksfile. That means any commit after: e840e576e05bd0e815f1080988e57d1182068f78 should work. However, do check the changelog, because it lists that potential breaking changes were made.

For example, if I wanted to test out that commit I put this in my Berksfile:

cookbook 'rvm', :github => 'martinisoft/chef-rvm', :ref => 'e840e576e05bd0e815f1080988e57d1182068f78'

See the Berkshelf Documentation for more supported syntax reference.

Then just run: berks update rvm && berks install, test it out perhaps with test-kitchen, vagrant, or chef-solo however you want. Then upload to chef server with berks upload rvm & deploy out to infrastructure nodes with chef-client.

martinisoft added a commit that referenced this pull request Jun 4, 2015
joshpasqualetto pushed a commit to CloudHealth/chef-rvm that referenced this pull request Jul 3, 2019
@lock
Copy link

lock bot commented Apr 25, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError: undefined method rvm_environment for #<Chef::Provider::Package::RVMRubygems:0x00000000ece280>
9 participants