Fixes inability to stop or delete containers if DOCKER_ARGS used#21
Merged
fnichol merged 2 commits intoApr 10, 2014
Merged
Conversation
Owner
|
@yacn, you are amazing, that is an awesome write up! So sorry this took weeks longer to pull in. |
fnichol
added a commit
that referenced
this pull request
Apr 10, 2014
Fixes inability to stop or delete containers if DOCKER_ARGS used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If you set
DOCKER_ARGSto anything indvm.conf, you will be unable to stop or delete containers. For an example of what happens, you can look over this gist.Solution
The solution is to modify the
sedcommand to save the-gparameter passed into Docker in its init file. This parameter is needed because the directory docker expects (/var/lib/docker) is a symlink to/mnt/sda/var/lib/docker. See this thread for more information.With the changes in this pull request, this will no longer happen:
(you can view the full output here)
I used this .kitchen.yml with this dvm.conf to confirm.