Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some graphs give an "Unable to display result" error only when embedded #441

Closed
Daniel-Mietchen opened this issue Jul 26, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@Daniel-Mietchen
Copy link
Collaborator

commented Jul 26, 2018

In
https://tools.wmflabs.org/scholia/topic/Q668 ,
the Co-author graph and the Co-occurring topics graph currently give this error, despite working fine when run separately via the "Edit this query" link.

Pinging @lucaswerkmeister

@Daniel-Mietchen

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 26, 2018

I have now checked this for a number of topics, and these two graphs always give this error - see
https://tools.wmflabs.org/scholia/topic/Q202864 (Zika virus) for another example.

As far as I can tell, things were fine still on Sunday, so I assume some change since has brought about this behaviour.

@Daniel-Mietchen

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 26, 2018

Opened a Phabricator ticket for this: https://phabricator.wikimedia.org/T200409 .

@fnielsen

This comment has been minimized.

Copy link
Owner

commented Jul 30, 2018

For one response I do not get any status code and I get JSON instead of HTML.

@fnielsen

This comment has been minimized.

Copy link
Owner

commented Jul 30, 2018

I suppose the embed script so the JSON type should be no surprise. The status code is strange though.

I was under the impression that it might have something to do with throttling on the WDQS side (because of the many parallel requests we are making). It is strange though that it is only the graphs where there is a problem. It is not just the topic aspect but also, e.g., the co-author graph panel in the author aspect, see, e.g., https://tools.wmflabs.org/scholia/author/Q8219 .

@fnielsen

This comment has been minimized.

Copy link
Owner

commented Jul 30, 2018

Ok. I see that it is taken care of on the Wikimedia Phabricator.

@Daniel-Mietchen

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 30, 2018

The matter is resolved on their end, and they recommend that we "should add the attributes referrerpolicy="origin" and sandbox="allow-scripts allow-same-origin allow-popups" to [our] iframe code", as per the following example

<iframe style="width: 80vw; height: 50vh; border: none;" src="./embed.html#%23Cats%0ASELECT%20%3Fitem%20%3FitemLabel%20%0AWHERE%20%0A%7B%0A%20%20%3Fitem%20wdt%3AP31%20wd%3AQ146.%0A%20%20SERVICE%20wikibase%3Alabel%20%7B%20bd%3AserviceParam%20wikibase%3Alanguage%20%22%5BAUTO_LANGUAGE%5D%2Cen%22.%20%7D%0A%7D" referrerpolicy="origin" sandbox="allow-scripts allow-same-origin allow-popups"></iframe>
@fnielsen

This comment has been minimized.

Copy link
Owner

commented Aug 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.