Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the pinged IP address to alfred notification output #3

Merged
merged 3 commits into from Sep 14, 2019

Conversation

@blizzrdof77
Copy link
Contributor

commented Sep 12, 2019

No description provided.

blizzrdof77 added 2 commits Sep 12, 2019
Changed "a" to "at" in the notification output text.
Copy link
Owner

left a comment

Thanks for the contribution! I have one minor question, but otherwise happy to integrate it.

src/info.plist Outdated Show resolved Hide resolved
Removing 'command' from ping for IP address in notification as requested by @fniephaus.

It was initially added because in rare cases, some shell integrations (i.e ZSH plugins) override the default command for ping with a function. In my case, ping is actually a function that accepts and parses URLs in addition to domains (e.g. ping https://github.com). 

However, the fallacy would actually be on the plugin in this case, and it is unlikely that this would be loaded into the bash shell within Alfred anyways, so we're removing it.
Copy link
Contributor Author

left a comment

@fniephaus - Updated!

Copy link
Owner

left a comment

LGTM...Thanks!

@fniephaus fniephaus merged commit b83abe4 into fniephaus:master Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.