Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should PropertyView subcontext with the correct data before creating the child view? #504

Open
adamvy-google opened this issue Dec 17, 2015 · 1 comment

Comments

@adamvy-google
Copy link
Member

commented Dec 17, 2015

js/foam/u2/PropertyView.js:63

@adamvy-google

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2015

If the child view imports data from the context, it will receive the incorrect data, and may even make a dynamic binding to it if it imports data$.

If data is going to be in the context, would it make more sense for the PropertyView to construct a sub-context with the appropriate data$ before constructing the view for child_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.