Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of UNSUBSCRIBE_EXCEPTION #528

Open
adamvy-google opened this issue Jan 13, 2016 · 3 comments

Comments

@adamvy-google
Copy link
Member

commented Jan 13, 2016

Use some programatic means of unsubscribing.

@adamvy-google adamvy-google added this to the foam2.0 milestone Jan 13, 2016

@kgrgreer

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2016

Pass subscription or subscription destructor as extra argument to listeners so that they can easily unsubscribe without throwing an Exception. Will avoid the use of non-error Exceptions and will be faster because try/catch blocks disable V8 JIT.

@shepheb

This comment has been minimized.

Copy link
Member

commented Jan 18, 2016

Isn't it only finally that destroys optimizations? In any case, we should do this.

@kgrgreer

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.