-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Templates v2] Add a proposal for how templates should work #534
[Templates v2] Add a proposal for how templates should work #534
Conversation
Thank you for this write up @movermeyer! |
ba10e60
to
0d32f97
Compare
dc1291b
to
8ff2f7b
Compare
I'm not sure what you want the end result of this PR to be. Do we merge this? Close this? |
@riccardoferretti I was thinking it might be nice to get some tasks up on the project board based on the proposal? cc @movermeyer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This proposal looks good to me.
Let's just be clear where we are asking for titles vs filenames, this can be confusing - I left a comment in that regard
@riccardoferretti Good idea! @movermeyer I imagine you have access to the project board? Do you think you can split the proposal out into PR-able tasks once the proposal is fully ironed out? |
8ff2f7b
to
7f9bff0
Compare
7f9bff0
to
dddbb59
Compare
@riccardoferretti @ingalless I've created new issues (#560-#566) to capture the work related to this proposal. |
Here's my proposal for how templates should work within Foam (as requested here).
You're going to want to view the rendered version of this file.
@riccardoferretti, did the file have to be called
docs/specs/templates-v2.md
? I went withdocs/proposals/templates-v2.md
instead.cc @ingalless @riccardoferretti