Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Templates v2] Add a proposal for how templates should work #534

Merged

Conversation

movermeyer
Copy link
Collaborator

@movermeyer movermeyer commented Mar 16, 2021

Here's my proposal for how templates should work within Foam (as requested here).

You're going to want to view the rendered version of this file.

@riccardoferretti, did the file have to be called docs/specs/templates-v2.md? I went with docs/proposals/templates-v2.md instead.


cc @ingalless @riccardoferretti

@movermeyer movermeyer marked this pull request as ready for review March 16, 2021 19:55
docs/proposals/templates-v2.md Show resolved Hide resolved
docs/proposals/templates-v2.md Outdated Show resolved Hide resolved
docs/proposals/templates-v2.md Outdated Show resolved Hide resolved
docs/proposals/templates-v2.md Outdated Show resolved Hide resolved
docs/proposals/templates-v2.md Outdated Show resolved Hide resolved
docs/proposals/templates-v2.md Outdated Show resolved Hide resolved
docs/proposals/templates-v2.md Show resolved Hide resolved
docs/proposals/templates-v2.md Outdated Show resolved Hide resolved
docs/proposals/templates-v2.md Outdated Show resolved Hide resolved
docs/proposals/templates-v2.md Outdated Show resolved Hide resolved
@ingalless
Copy link
Member

Thank you for this write up @movermeyer!

@movermeyer movermeyer marked this pull request as draft March 17, 2021 20:54
@movermeyer movermeyer changed the title Add a proposal for how templates should work (Templates v2) WIP: Add a proposal for how templates should work (Templates v2) Mar 17, 2021
@movermeyer movermeyer force-pushed the mo.template_v2_proposal branch 2 times, most recently from dc1291b to 8ff2f7b Compare March 28, 2021 18:58
@movermeyer
Copy link
Collaborator Author

@riccardoferretti @ingalless

I'm not sure what you want the end result of this PR to be. Do we merge this? Close this?
I've started implementation of ${title} here

@movermeyer movermeyer changed the title WIP: Add a proposal for how templates should work (Templates v2) Add a proposal for how templates should work (Templates v2) Mar 28, 2021
@movermeyer movermeyer marked this pull request as ready for review March 28, 2021 19:00
@ingalless
Copy link
Member

@riccardoferretti I was thinking it might be nice to get some tasks up on the project board based on the proposal?

cc @movermeyer

Copy link
Collaborator

@riccardoferretti riccardoferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This proposal looks good to me.
Let's just be clear where we are asking for titles vs filenames, this can be confusing - I left a comment in that regard

docs/proposals/templates-v2.md Outdated Show resolved Hide resolved
@ingalless
Copy link
Member

@riccardoferretti Good idea! @movermeyer I imagine you have access to the project board? Do you think you can split the proposal out into PR-able tasks once the proposal is fully ironed out?

@movermeyer
Copy link
Collaborator Author

@riccardoferretti @ingalless I've created new issues (#560-#566) to capture the work related to this proposal.

@riccardoferretti riccardoferretti merged commit 567c87c into foambubble:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants