New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any url redirects to the home page #773

Closed
sylque opened this Issue Oct 30, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@sylque
Copy link
Contributor

sylque commented Oct 30, 2018

If I email an url to my friend (such as https://focallocal.org/page/p7cEkH8MmBDnLF5Qp) and he clicks on the link, he is redirected to the home page (https://focallocal.org/home) and cannot see the page I wanted him to see.

This issue has appeared in new-master and is due to this line:
https://github.com/focallocal/fl-maps/blob/master/imports/client/ui/app.js#L63

@AndyatFocallocal

This comment has been minimized.

Copy link
Member

AndyatFocallocal commented Oct 30, 2018

@kevin-06-huang has already begun work on this. your note here might help him find the cause, Kevin is the due to the 404 redirect hack

@AgentBoo

This comment has been minimized.

Copy link
Contributor

AgentBoo commented Oct 30, 2018

I commented out that line in my pull request #772. I was fixing the modal and that line made the modal always redirect to /home. It didn't make sense and I couldn't find where else this line could be essential + I couldn't reproduce a 404.

@AndyatFocallocal

This comment has been minimized.

Copy link
Member

AndyatFocallocal commented Oct 30, 2018

@AgentBoo it's very helpful. can you message Kevin on Slack and just let him know what you did. is that in both branches, or just new-master?

@AgentBoo

This comment has been minimized.

Copy link
Contributor

AgentBoo commented Oct 31, 2018

It's in both.

@sylque

This comment has been minimized.

Copy link
Contributor

sylque commented Nov 10, 2018

Looks ok now.

@sylque sylque closed this Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment