From 9b816a32108ca5f1c8111258bc45d02a1d189c1c Mon Sep 17 00:00:00 2001 From: Jasper Verelst Date: Wed, 19 Jun 2019 19:55:28 +0200 Subject: [PATCH] Code review remarks - remove unused include - document usage of different std lib on mac - remove trailing semicolon --- setup.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/setup.py b/setup.py index e4ccb1429..d33c45e8d 100644 --- a/setup.py +++ b/setup.py @@ -26,7 +26,7 @@ import distutils.ccompiler from distutils.dep_util import newer from distutils.command.install import install as _install -import sys, glob, os, fnmatch, platform +import sys, glob, os, fnmatch import subprocess import shlex @@ -463,8 +463,9 @@ def run(self): else: vidInclude = ['.'] -extra_compile_args_pitch = []; -extra_link_args_pitch = []; +extra_compile_args_pitch = [] +extra_link_args_pitch = [] +# As of mac os version 10.13.6 (high sierra), xcode 10 is supported. Xcode 10 requires the use of the libc++ standard library. if os.uname()[0] == "Darwin" and pkg_resources.parse_version(os.uname()[2]) >= pkg_resources.parse_version("17.7.0"): print("success") extra_compile_args_pitch.append("-stdlib=libc++")