Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add albums #7

merged 20 commits into from May 28, 2016

Add albums #7

merged 20 commits into from May 28, 2016


Copy link

@fofr fofr commented May 28, 2016

An album is a post containing references to already uploaded photos. Using the tag {% photo photo-slug %}Caption{% endphoto %} a photo can be referenced in markdown. At the time of a post rendering, this is converted to some markup and the caption is parsed as markdown. When the view is rendered the custom <photo> tag is swapped out; the data-slug value is used to lookup the post, and the post is used to render a partial, which replaces the custom tag.

  • Add an album list view
  • Add an all photos list view
  • Add album layout
  • Use cover to indicate an albums cover photo
  • Add a new PostFinder class for looking up content by slug




fofr added 20 commits May 24, 2016
Expanding photos in posts will require a look-up by slug
{% photo photo-slug %}Caption{% endphoto %}

* Renders some simple markup with a fake tag
* Uses a helper in the view to find these tags and replace them with a
* Uses the slug to find the post, which leads to the data needed to
populate the partial
* Move page partial out into `page.ejs` one level up
* Will be used for album posts
* Rename sets to albums
* Base styles on existing photo classes
* <footer> doesn’t apply to the <figure> tag
* Make camera EXIF match photo details, so that wrapping text in the
template looks more cohesive.
Use pages for now, but this will diverge eventually.
The context of navigation within the album pages will suggest
left/right would switch between images within the album – which it
* Show a list of all albums at /albums/
* Show all photos at /photos/
* Remove 301 redirect
* DRY up partials
* Default archive partial to use the page’s posts or all site posts if
none specified
Use a portrait image, scale this down and create natural breakpoints
where the text inside the image begins to overlap.

Use the 0 height, % padding trick for scaling photos with correct
aspect ratio.
At thinner viewports the difference in line-height between the masthead
and the content title would look peculiar. Make them match and add some
spacing between them.
Make the albums discoverable.
@fofr fofr merged commit ecd2b31 into master May 28, 2016
@fofr fofr deleted the sets-and-blogs branch May 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.