Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
How to fix deprecation warning: "The format Fog::CDN::AWS is deprecated" #466
Hi, I'd like to help fix this warning:
Do we need to eg.
See also fog/fog-core#241
grep fog Gemfile gem 'fog-aws' bundle | grep fog Using fog-core 2.1.2 Using fog-json 1.2.0 Using fog-xml 0.1.3 Using fog-aws 3.0.0
You will need to change the convention from
The issue is that there is no convention among the providers so we have both ways defined here and there.
So we are deprecating the first one in favor of the second one. That should allow us to have the same implementation in all providers.
Is this something you think I can tackle? If so, I'll attempt a PR. Do you want to try to define both, or are you willing to make a breaking change (ie. release new major version)?
It will have to be a breaking change so a new major version will be released. I believe you can tackle it. It just a change in the name. =) Em qua, 5 de set de 2018 19:27, Jared Beck <firstname.lastname@example.org> escreveu:…
You will need to change the convention from Fog::CDN::AWS to Fog::AWS::CDN. Is this something you think I can tackle? If so, I'll attempt a PR. Do you want to try to define both, or are you willing to make a breaking change (ie. release new major version)? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#466 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AApEuJwsl25J7zDKRlVZDCn6qYX2hmigks5uYE_YgaJpZM4WbSlx> .
It might be fine to have both? I think the issue at hand here is that, by default, we require the deprecated version. I think we could probably do this?
I think that way we could perhaps avoid the requirement of a major version bump.
@plribeiro3000 what do you think?
@jaredbeck you can definitely go for it, we are here to support you.
added a commit
Sep 6, 2018
referenced this issue
Sep 10, 2018
@jaredbeck Just for context, few other constants that will probably need renaming:
I believe when you guys are done with the first one I can submit pull requests for the others.