Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #24808 - Fix host boolean values in update #41

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
2 participants
@shiramax
Copy link
Collaborator

commented Oct 24, 2018

Updating a Host caused the parameters - Stateless, Start in Pause Mode, Delete Protection and more to be checked.

@shiramax shiramax force-pushed the shiramax:24808 branch from 435d7fe to 2ee8a32 Oct 24, 2018

@shiramax shiramax force-pushed the shiramax:24808 branch 5 times, most recently from 3d6dc14 to 029e844 Nov 6, 2018

@@ -100,6 +100,8 @@ def get_attr_value(value, opts)
else
if value.class.respond_to?(:parent) && value.class.parent == OvirtSDK4
value.id if value.respond_to?(:id)
elsif [true, false].include? value

This comment has been minimized.

Copy link
@adamruzicka

adamruzicka Nov 8, 2018

Collaborator

Wouldn't it be a bit nicer to add TrueClass, FalseClass to line 79?

@shiramax shiramax force-pushed the shiramax:24808 branch from 029e844 to 623ea94 Nov 11, 2018

@shiramax

This comment has been minimized.

Copy link
Collaborator Author

commented Nov 11, 2018

@adamruzicka thanks!
please review again :)

@adamruzicka
Copy link
Collaborator

left a comment

Looks good to me

@adamruzicka adamruzicka merged commit 07ccd5d into fog:master Nov 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adamruzicka

This comment has been minimized.

Copy link
Collaborator

commented Nov 14, 2018

Thanks @shiramax !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.