Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor storage pod handling #28

Merged
merged 1 commit into from Feb 11, 2016
Merged

refactor storage pod handling #28

merged 1 commit into from Feb 11, 2016

Conversation

timogoebel
Copy link
Member

Just a little refactoring for vm cloning to also check whether storage_pod is nil and not just if the key exists

@jrgarcia
Copy link
Contributor

👍

jrgarcia added a commit that referenced this pull request Feb 11, 2016
@jrgarcia
Merge pull request #28 from timogoebel/refactor_clone_storage_pod
327c1ae 
Refactor storage pod handling
@jrgarcia jrgarcia merged commit 327c1ae into fog:master Feb 11, 2016
@iNecas
Copy link
Contributor

iNecas commented Mar 4, 2016

Without this patch, the vm_clone is broken as the original call for get_storage_pod has different number of arguments. (see http://projects.theforeman.org/issues/14051). Would you mind releasing 0.6.1 with this, as it pretty limits the usage.

@jrgarcia
Copy link
Contributor

jrgarcia commented Mar 4, 2016

@iNecas Released https://rubygems.org/gems/fog-vsphere/versions/0.6.1

@iNecas
Copy link
Contributor

iNecas commented Mar 4, 2016

Thanks @jrgarcia !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timogoebel @jrgarcia @iNecas