Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS security group tests have become unstable #2932

Closed
tokengeek opened this issue May 20, 2014 · 4 comments
Closed

AWS security group tests have become unstable #2932

tokengeek opened this issue May 20, 2014 · 4 comments
Labels
testing

Comments

@tokengeek
Copy link
Member

I've been so busy travelling to the fog summit I missed that tests/aws/requests/compute/security_group_tests.rb has been failing randomly on different Travis settings for a while.

https://travis-ci.org/fog/fog/jobs/25614603#L1105 is one of many failures.

It seems unstable enough that every build is failing and what I have noticed (but didn't look at further) is lots of people going "Hey it's not my changes!" about something so this hasn't been looked at.

Needs fixing or I'll disable the test.
@geemus
Copy link
Member

geemus commented May 22, 2014

👍 to disabling, at least for the time being.

@krames
Copy link
Member

krames commented May 22, 2014

Sounds good to me.

tokengeek added a commit that referenced this issue May 26, 2014
@tokengeek
[GH-2932] Disable brittle test
6a2297a 
The AWS security group tests have been very unstable with 2 failures on
Travis per build. The majority is the mocked version of
`describe_security_groups` not working.

We have decided to disable it until someone makes time to figure out the
bug since it is affecting every build.

See https://travis-ci.org/fog/fog/jobs/25614603#L1105
@tokengeek
Copy link
Member Author

It's happening on describe_security_groups in the setup so I've made the entire test pending. More than I would have liked.

It is probably a race condition in the mock. It passes locally all times and when re-ran on travis it usually passes.

I seem to be kicking off 3 or 4 additional re-runs to get tests green.

tokengeek added a commit that referenced this issue May 26, 2014
@tokengeek
Merge pull request #2952 from fog/disable_buggy_aws_test
6c6a118 
[GH-2932] Disable brittle test
@plribeiro3000 plribeiro3000 mentioned this issue Jan 15, 2015
Closed
@plribeiro3000
Copy link
Member

Closed in favor of fog/fog-aws#16

@fog fog locked and limited conversation to collaborators Jan 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@geemus @tokengeek @krames @plribeiro3000