Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rackspace Provide networks attribute to allow create via collection to enable networks #1761

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@chrisroberts
Copy link
Contributor

chrisroberts commented Apr 17, 2013

This allows for usage like:

server = connection.servers.create(
  :name => _name,
  :image_id => _image_id,
  :flavor_id => _flavor_id,
  :metadata => _metadata,
  :networks => _networks
)
@geemus

This comment has been minimized.

Copy link
Member

geemus commented Apr 18, 2013

@chrisroberts - thanks!

@krames - could you take a look? Thanks!

@krames

This comment has been minimized.

Copy link
Member

krames commented Apr 18, 2013

@geemus Sure!

This pull request seems awful similar to #1578 which was never merged. I am going to do a little more research and get back to you.

@krames

This comment has been minimized.

Copy link
Member

krames commented Apr 18, 2013

@chrisroberts Thanks for pull request! This is not the first time I have been run into this and I don't think adding networks to a server follows the principal of least surprise.

The problem with adding an attribute, is that this attribute will never be populated outside of server creation and the fear is that it might lead to confusion. I took a stab at implementing this and I think it addresses adding a server without adding an unneeded attribute. Can you take a look at my implementation #1766 and let me know if it meets your use case.

@krames

This comment has been minimized.

Copy link
Member

krames commented Apr 19, 2013

I am closing this as it has been addressed in pull request #1766.

@krames krames closed this Apr 19, 2013

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 27, 2014

Coverage Status

Changes Unknown when pulling 69cfa8a on chrisroberts:enhancement/rackspace-networks into * on fog:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.