Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update to Google Compute Engine API v1 #2494

Merged
merged 3 commits into from Dec 22, 2013

Conversation

Projects
None yet
6 participants
Contributor

carlossg commented Dec 19, 2013

plus some disk goodies

Coverage Status

Coverage remained the same when pulling 11d48c6 on maestrodev:gce-v1 into 13090e9 on fog:master.

carlossg and others added some commits Dec 18, 2013

@carlossg carlossg [google][compute] Update to API v1
Simplify attachment of boot disk, get_as_boot_disk no longer needed
Add missing Disk.get_object method
Allow setting deviceName when attaching a disk
Add disks mocks
4c2736d
@dougforpres @carlossg dougforpres + carlossg [google][compute] Add support for blank disks (i.e. remove code that …
…required only image or snapshot based disks to be created)
dd72a93
@carlossg carlossg [google] Handle 500 errors from GCE fafebc1
Contributor

carlossg commented Dec 19, 2013

travis is failing in other providers' tests, rebasing against v1.19.0 to see if that works

Coverage Status

Coverage remained the same when pulling dd72a93 on maestrodev:gce-v1 into 13090e9 on fog:master.

Owner

geemus commented Dec 20, 2013

Thanks!

@icco - could you review? Thanks!

Member

icco commented Dec 22, 2013

This looks pretty good. Beat me to it :p

Thanks!

@icco icco added a commit that referenced this pull request Dec 22, 2013

@icco icco Merge pull request #2494 from maestrodev/gce-v1
[google|compute] Update to Google Compute Engine API v1
e3d283e

@icco icco merged commit e3d283e into fog:master Dec 22, 2013

1 check failed

default The Travis CI build failed
Details

@ghost ghost assigned icco Dec 22, 2013

Contributor

allomov commented Dec 22, 2013

@carlossg just was working on the similar thing. glad to see someone how is interested too. GCE rocks 🤘

@allomov allomov added a commit to allomov/fog that referenced this pull request Dec 22, 2013

@allomov allomov merge with master after #2494 changes aa27e20
Owner

geemus commented Dec 23, 2013

Thanks!

On Sun, Dec 22, 2013 at 7:11 AM, Alexander Lomov
notifications@github.comwrote:

@carlossg https://github.com/carlossg just was working on the similar
thing. glad to see someone how is interested too. GCE rocks [image:
🤘]


Reply to this email directly or view it on GitHubhttps://github.com/fog/fog/pull/2494#issuecomment-31089036
.

@carlossg carlossg deleted the maestrodev:gce-v1 branch Dec 26, 2013

@carlossg I think this disk should be removed somewhere. what do you think ?

Contributor

carlossg replied Jan 19, 2014

for the live tests, yes, should be removed

@martinb3 martinb3 added a commit to martinb3/fog that referenced this pull request Oct 5, 2015

@martinb3 martinb3 Ensure root user behaves like Rackspace defaults
Swap the logic for `:no_passwd_lock` making it `:passwd_lock`. Per #3715, we really should make our defaults the same as Rackspace's. Because so many projects rely on the fog library, and can't all add this option to pass through, we should default to the same behaviors you'd get on vanilla Rackspace.

This change is backwards compatible, but still warns those who have explicitly set :no_passwd_lock to any specific value.

Fixes #3715. RE: #2494.
0322ff2

@martinb3 martinb3 added a commit to martinb3/fog that referenced this pull request Oct 5, 2015

@martinb3 martinb3 Ensure root user behaves like Rackspace defaults
Swap the logic for `:no_passwd_lock` making it `:passwd_lock`. Per #3715, we really should make our defaults the same as Rackspace's. Because so many projects rely on the fog library, and can't all add this option to pass through, we should default to the same behaviors you'd get on vanilla Rackspace.

This change is backwards compatible, but still warns those who have explicitly set :no_passwd_lock to any specific value.

Fixes #3715. RE: #2494.
7ad7d3d

@martinb3 martinb3 added a commit to martinb3/fog that referenced this pull request Oct 5, 2015

@martinb3 martinb3 Ensure root user behaves like Rackspace defaults
Swap the logic for `:no_passwd_lock` making it `:passwd_lock`. Per #3715, we really should make our defaults the same as Rackspace's. Because so many projects rely on the fog library, and can't all add this option to pass through, we should default to the same behaviors you'd get on vanilla Rackspace.

This change is backwards compatible, but still warns those who have explicitly set :no_passwd_lock to any specific value.

Fixes #3715. RE: #2494.
c8ac207

@martinb3 martinb3 added a commit to martinb3/fog that referenced this pull request Oct 5, 2015

@martinb3 martinb3 Ensure root user behaves like Rackspace defaults
Swap the logic for `:no_passwd_lock` making it `:passwd_lock`. Per #3715, we really should make our defaults the same as Rackspace's. Because so many projects rely on the fog library, and can't all add this option to pass through, we should default to the same behaviors you'd get on vanilla Rackspace.

This change is backwards compatible, and closer to the default Rackspace build, but still warns those who have explicitly set :no_passwd_lock to any specific value.

Fixes #3715. RE: #2494.
cfcffe1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment