Skip to content

Allow filter options to be passed to Storage::AWS::File#each #2654

Closed
wants to merge 1 commit into from

4 participants

@DanKnox
DanKnox commented Feb 7, 2014

This is a very small pull request that allows for specifying the same options you can pass to File#all to File#each as well.

I personally needed it to be able to paginate through more than 1,000 objects on S3 with a prefix option set.

If you think you may be interested in accepting this I can look into adding test coverage for it.

@coveralls

Coverage Status

Coverage remained the same when pulling f42ad9f on DanKnox:allow_options_for_each into 6788c8e on fog:master.

@geemus
fog member
geemus commented Feb 7, 2014

@DanKnox - yeah, sounds like a good plan. With fleshed out tests I think it would be a great addition. Just let me know if you have questions or anything I can help with. Thanks!

@plribeiro3000
fog member

Thanks for your interest, but due to inactivity we are closing this issue to clean things up. Please comment if you have questions or concerns. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.