Update to attempt to alleviate confusion between Directory.new and get. #2715

Merged
merged 3 commits into from Feb 26, 2014

Conversation

Projects
None yet
5 participants
@elight
Contributor

elight commented Feb 26, 2014

May want to have Directory metadata load only on #each instead of #get. If so, we'll want to revisit this later. But this is a stop gap because of issues like #2714 coming up.

/cc @krames

elight added some commits Feb 26, 2014

@mikhailov

This comment has been minimized.

Show comment Hide comment
@mikhailov

mikhailov Feb 26, 2014

@elight hey, thanks for the quick changes!!! may I recommend to update docs with something like this:

These 2 calls are identical except the first one retrieve the 10K files from the directory:
dir = service.directories.get "blue"
dir = service.directories.new :key => "blue"

@elight hey, thanks for the quick changes!!! may I recommend to update docs with something like this:

These 2 calls are identical except the first one retrieve the 10K files from the directory:
dir = service.directories.get "blue"
dir = service.directories.new :key => "blue"
@elight

This comment has been minimized.

Show comment Hide comment
@elight

elight Feb 26, 2014

Contributor

@mikhailov What do you think?

Contributor

elight commented Feb 26, 2014

@mikhailov What do you think?

@mikhailov

This comment has been minimized.

Show comment Hide comment
@mikhailov

mikhailov Feb 26, 2014

@elight this is brilliant, you have made my day!

@elight this is brilliant, you have made my day!

@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Feb 26, 2014

Coverage Status

Coverage remained the same when pulling 9e10396 on rackspace_storage_docs into 573591f on master.

Coverage Status

Coverage remained the same when pulling 9e10396 on rackspace_storage_docs into 573591f on master.

elight added a commit that referenced this pull request Feb 26, 2014

Merge pull request #2715 from fog/rackspace_storage_docs
Update to attempt to alleviate confusion between Directory.new and get.

@elight elight merged commit dcfabec into master Feb 26, 2014

1 check passed

default The Travis CI build passed
Details
@elight

This comment has been minimized.

Show comment Hide comment
@elight

elight Feb 26, 2014

Contributor

@mikhailov Glad to be of service. 😄

Contributor

elight commented Feb 26, 2014

@mikhailov Glad to be of service. 😄

@geemus

This comment has been minimized.

Show comment Hide comment
@geemus

geemus Feb 26, 2014

Member

Thanks!

On Wed, Feb 26, 2014 at 4:34 PM, Evan Light notifications@github.comwrote:

@mikhailov https://github.com/mikhailov Glad to be of service. [image:
😄]

Reply to this email directly or view it on GitHubhttps://github.com/fog/fog/pull/2715#issuecomment-36186414
.

Member

geemus commented Feb 26, 2014

Thanks!

On Wed, Feb 26, 2014 at 4:34 PM, Evan Light notifications@github.comwrote:

@mikhailov https://github.com/mikhailov Glad to be of service. [image:
😄]

Reply to this email directly or view it on GitHubhttps://github.com/fog/fog/pull/2715#issuecomment-36186414
.

@krames

This comment has been minimized.

Show comment Hide comment
@krames

krames Feb 27, 2014

Member

@elight good idea! 👍

Member

krames commented Feb 27, 2014

@elight good idea! 👍

@tokengeek tokengeek deleted the rackspace_storage_docs branch Mar 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment