Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement orchestration models #2971

Closed
wants to merge 44 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@chrisroberts
Copy link
Contributor

chrisroberts commented Jun 2, 2014

Adds orchestration models for AWS and RS. Still a WIP. Looking for feedback. Related to/dependent on: fog/fog-core#45


def initialize(*args)
super
self.resource_name = self.logical_resource_id

This comment has been minimized.

@krames

krames Jun 2, 2014

Member

I can definitely imagine scenarios where resource_name and logical_resource_id can get out of sync. Can you see that being an issue?

This comment has been minimized.

@chrisroberts

chrisroberts Jun 2, 2014

Author Contributor

What scenarios would you see this occurring?

This comment has been minimized.

@krames

krames Jun 3, 2014

Member

Someone could try to manually update the two attributes or call the reload method.

If these values are suppose to be in sync then we could try something like this:

def resource_name
  attributes[: logical_resource_id]
end

def resource_name=(val)
  attributes[: logical_resource_id]=val
end

This comment has been minimized.

@chrisroberts

chrisroberts Jun 3, 2014

Author Contributor

Ah, I see what you mean. Any issue with just aliasing?

alias_method :resource_name, :logical_resource_id
alias_method :resource_name=, :logical_resource_id=

This comment has been minimized.

@krames

krames Jun 3, 2014

Member

Good call! That's probably the better way to do it.

@krames

This comment has been minimized.

Copy link
Member

krames commented Jun 3, 2014

Thanks for the PR BTW!

I just noticed your PR for fog-core. I think am going to jump over there and start looking at that one first.

@chrisroberts

This comment has been minimized.

Copy link
Contributor Author

chrisroberts commented Aug 6, 2014

The openstack orchestration bits still need an overhaul, but I need to get a local instance up so I can properly test it. Will run that through in another PR

@geemus

This comment has been minimized.

Copy link
Member

geemus commented Aug 11, 2014

Sounds like a plan. Will take a closer look here once we land the fog-core changes. Thanks!

chrisroberts added some commits Mar 28, 2014

Update how we store attribute data
These changes allow for easier restoration of stack
information from cached json serializations.

@chrisroberts chrisroberts force-pushed the chrisroberts:feature/orchestration branch from 3842c32 to d06ff20 Sep 23, 2014

@kbrock

This comment has been minimized.

Copy link

kbrock commented Oct 9, 2014

@chrisroberts did you get a chance to put in a PR for the openstack version?
Does it make sense to pull rackspace out into its own pr? (Not sure if a PR per provider makes it easier to review / quicker to get it merged.)

Thanks

@plribeiro3000

This comment has been minimized.

Copy link
Member

plribeiro3000 commented Dec 23, 2014

@chrisroberts @geemus Whats the status of this?

@geemus

This comment has been minimized.

Copy link
Member

geemus commented Dec 23, 2014

Good question. Maybe also @mdarby who was working on the rackspace side of this. I'm not sure personally where this is at...

@mdarby

This comment has been minimized.

Copy link

mdarby commented Dec 23, 2014

Rackspace Orchestration was merged in a while back.

@chrisroberts

This comment has been minimized.

Copy link
Contributor Author

chrisroberts commented Dec 23, 2014

Unfortunate to see the code made less generalized (removal of fog-core integrations) and all mention of my work fully removed there. I left a note in the fog-core PR related to this one on people picking this back up. It stalled on implementation of tests but no clear examples on how abstract tests are to be written.

@geemus

This comment has been minimized.

Copy link
Member

geemus commented Dec 23, 2014

@chrisroberts not sure I totally follow. Definitely happy to discuss and help out however I can though.

@plribeiro3000

This comment has been minimized.

Copy link
Member

plribeiro3000 commented Jan 15, 2015

@chrisroberts I think this PR sits for so long it is gonna need a rebase. The aws code is not in fog anymore. Could you take care of that?

Thanks!

@plribeiro3000

This comment has been minimized.

Copy link
Member

plribeiro3000 commented Feb 19, 2015

@chrisroberts This PR needs a full rebase. AWS was extracted to fog-aws and soon Rackspace gotta be extracted to fog-rackspace. The changes you made in bin gonna be reviewed again since @tokengeek is refactoring that part out and maybe we are going to deprecate that part as well.

I'm closing this PR but let me know if you rebased it.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.