cloud_init support in ovirt #3250

Merged
merged 1 commit into from Dec 15, 2014

Projects

None yet

3 participants

@karmab
Contributor
karmab commented Nov 7, 2014

this pr brings cloud_init support for ovirt provider by means of providing a user_data hash upon starting of the vm.
the rbovirt related part is under review at abenari/rbovirt#48

@geemus
Member
geemus commented Nov 11, 2014

@karmab Cool, please ping me when the rbovirt part is landed (I presume we will need to bump rbovirt dependency version also). Thanks!

@karmab karmab referenced this pull request in theforeman/foreman Nov 16, 2014
Closed

Fixes #8289 - cloudinit from rhev/ovirt support #1939

@dLobatog dLobatog commented on the diff Nov 17, 2014
lib/fog/ovirt/models/compute/server.rb
@@ -79,11 +79,6 @@ def add_volume attrs
service.add_volume(id, attrs)
end
- def update_volume attrs
@dLobatog
dLobatog Nov 17, 2014 Contributor

Why?

@karmab
karmab Nov 17, 2014 Contributor

seems like a crappy typo...will correct it today...

@karmab
Contributor
karmab commented Nov 17, 2014

fixed the update_volume attrs typo removal, sorry for this one...

@karmab
Contributor
karmab commented Dec 11, 2014

rbovirt PR was merged and rbovirt upgraded to version 0.0.31 to reflect the changes, so i think you can now review/merge this PR too

@geemus
Member
geemus commented Dec 11, 2014

@karmab I think maybe we will want to add a dependency of 0.0.31 or greater to rbovirt to ensure this would work for users? Thanks!

@karmab
Contributor
karmab commented Dec 12, 2014

indeed. should i edit fog.gemspec as part of the PR ?

@geemus
Member
geemus commented Dec 12, 2014

Yeah, if you could just update the development dependency there appropriately I think we should be ready to merge. Just ping me when it is ready and I'll work on getting this in. Thanks!

@karmab
Contributor
karmab commented Dec 13, 2014

updated development dependency and rebased commits into a single one

@geemus
Member
geemus commented Dec 15, 2014

Thanks!

@geemus geemus merged commit 8ec90b8 into fog:master Dec 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment