vm_clone used regular virtual switches no matter what type of portgroup ... #3438

Merged
merged 2 commits into from Mar 2, 2015

Projects

None yet

4 participants

@sofam
Contributor
sofam commented Feb 14, 2015

...was named, changed it to look up and handle distributed virtual switches correctly. @nirvdrum

sofam added some commits Feb 14, 2015
@sofam sofam vm_clone used regular virtual switches no matter what kind of portgro…
…up was named, changed it to look up and handle distributed virtual switches correctly.
00425b6
@sofam sofam Fixed Ruby 1.8 breaking comma b917eca
@nirvdrum nirvdrum self-assigned this Feb 14, 2015
@sofam
Contributor
sofam commented Feb 24, 2015

@nirvdrum any comments on this?

@nirvdrum
Contributor

Sorry. I forgot about this. Just to be clear, this is a problem you're seeing even with the merged fix from #3121 applied?

@sofam
Contributor
sofam commented Feb 24, 2015

@nirvdrum it's actually unrelated (kind of) because the problem lies in the port backing chosen in vm_clone, before my pull request vm_clone would just create a VirtualEthernetCardNetworkBackingInfo port backing, no matter what kind of network was specified, my pull request checks the type of the network chosen, if it's a normal vSwitch it uses VirtualEthernetCardNetworkBackingInfo, and if it's a distributed port group it uses VirtualEthernetCardDistributedVirtualPortBackingInfo.

@nirvdrum
Contributor
nirvdrum commented Mar 2, 2015

This looks good. The code formatting doesn't match the new guidelines, but I can clean that up easily enough. Thanks!

@nirvdrum nirvdrum merged commit dfeae1a into fog:master Mar 2, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@geemus
Member
geemus commented Mar 2, 2015

Thanks!

On Mon, Mar 2, 2015 at 7:38 AM, Kevin Menard notifications@github.com
wrote:

Merged #3438 #3438.

Reply to this email directly or view it on GitHub
#3438 (comment).

@coveralls
coveralls commented Sep 16, 2016 edited

Coverage Status

Changes Unknown when pulling b917eca on sofam:vm_clone-fix into * on fog:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment