Fixes #3084: Implement OpenStack Identity V3 API #3549

Closed
wants to merge 4 commits into
from

Projects

None yet

4 participants

@dhague
Contributor
dhague commented Apr 30, 2015

Fog::Identity::OpenStack.new() will return either a V2 API object or a V3 API object depending on the auth URL
Fog::OpenStack::Core.authenticate switches on the auth URL to call the V2 or V3 authentication API

Old implementation Fog::Identity::OpenStack is now at Fog::Identity::OpenStack::V2, and the related models & requests have been moved from /identity to /identity_v2.

Tests for the v3 API have been done as VCR recordings against a Keystone (Juno) installation.

@TerryHowe
Contributor

I'd like to look at it closer, but giving it a quick look, looks great!

@dhague
Contributor
dhague commented May 1, 2015

This is getting very frustrating - the build is still failing with Ruby 1.8.7, but not for any reason to do with this pull request as far as I can see.
I run Ubuntu 14.04.2 and I can't get RVM to install 1.8.7 so it's pretty much impossible for me to test that version locally - apologies for all the micro-commits to get this far.

@geemus
Member
geemus commented May 4, 2015

@dhague sorry to hear about the issues, I'll try to dig in and help out soon (it's been a super busy week).

@dhague
Contributor
dhague commented May 5, 2015

Seems like a conflict between minitest and RSpec. Working on it now...

@geemus
Member
geemus commented May 5, 2015

@dhague ah, yeah I could see how that might be an issue. I didn't realize there were some of both here (at some point a lot of things have become a bit of a blur with so many moving parts). Just let me know if you have questions or anything I can further help with. Thanks!

@dhague
Contributor
dhague commented May 5, 2015

Just about fixed it now - thanks

@dhague
Contributor
dhague commented May 5, 2015

Just let me know if you'd prefer me to rebase & squash and submit this as one commit instead of nine commits.

@geemus
Member
geemus commented May 5, 2015

Awesome, I commend you on sticking to it through that painful bit. I'm fine with more commits, but you are welcome to rebase & squash also. I'm getting toward my EOD, so will probably try to review/merge in whatever form it is tomorrow.

@dhague
Contributor
dhague commented May 6, 2015

Rebased and squashed - hopefully a bit easier to review.

@dhague
Contributor
dhague commented May 7, 2015

:-(

@TerryHowe
Contributor

Sort of the merge issue, lgtm!

@geemus
Member
geemus commented May 7, 2015

Yeah, in general seems good, looks like some of the squash went bad though, tests appear to have an undefined constant issue now :(

@dhague sorry this turned out to be so painful, hopefully we are nearly done with it at least.

dhague added some commits Apr 29, 2015
@dhague dhague Fixes #3084: Implement OpenStack Identity V3 API
Fog::Identity::OpenStack.new() will return either a V2 API object or a V3 API object depending on the auth URL
Fog::OpenStack::Core.authenticate switches on the auth URL to call the V2 or V3 authentication API
bbed281
@dhague dhague Fixes #3084: Some refactoring to make better use of environment varia…
…bles in the tests

Also, now expects OpenStack Identity V3 service to be of type 'identityv3'
a593005
@dhague dhague Fixes #3084: Fix build - ran OK locally with 1.8.7, but not in Travis 792e22c
@dhague dhague Fixes #3084: Fix build better - runs OK locally with 1.8.7 3bc5d23
@dhague dhague closed this May 8, 2015
@coveralls

Coverage Status

Changes Unknown when pulling 3bc5d23 on dhague:master into ** on fog:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment