Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dynect] Move dynect bin from fog to fog-dynect. #3672

Merged
merged 1 commit into from Aug 24, 2015

Conversation

@glennpratt
Copy link
Member

commented Aug 24, 2015

fog/fog-dynect#2 needs to land first.

@glennpratt glennpratt referenced this pull request Aug 24, 2015
@geemus

This comment has been minimized.

Copy link
Member

commented Aug 24, 2015

Looks like there is a require to remove in lib/fog/bin.rb also (see failing tests). Could you also nuke that and make sure tests pass? Thanks!

@plribeiro3000

This comment has been minimized.

Copy link
Member

commented Aug 24, 2015

I think you will need a new release of fog-dynect and then this will work. (the tests shall pass)

@glennpratt glennpratt force-pushed the glennpratt:extract-dynect-bin branch from ebb3966 to 603ae56 Aug 24, 2015

@glennpratt glennpratt force-pushed the glennpratt:extract-dynect-bin branch from 603ae56 to 6f1b2f2 Aug 24, 2015

@glennpratt

This comment has been minimized.

Copy link
Member Author

commented Aug 24, 2015

Released fog-dynect and updated with a version constraint.

@plribeiro3000

This comment has been minimized.

Copy link
Member

commented Aug 24, 2015

this time the build will succeed.

plribeiro3000 added a commit that referenced this pull request Aug 24, 2015
Merge pull request #3672 from glennpratt/extract-dynect-bin
[dynect] Move dynect bin from fog to fog-dynect.

@plribeiro3000 plribeiro3000 merged commit 9be1b00 into fog:master Aug 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@plribeiro3000

This comment has been minimized.

Copy link
Member

commented Aug 24, 2015

There you go. =)

@plribeiro3000

This comment has been minimized.

Copy link
Member

commented Aug 24, 2015

Thanks!

@geemus

This comment has been minimized.

Copy link
Member

commented Aug 25, 2015

Thanks!

On Mon, Aug 24, 2015 at 4:33 PM, Paulo Henrique Lopes Ribeiro <
notifications@github.com> wrote:

Thanks!


Reply to this email directly or view it on GitHub
#3672 (comment).

@coveralls

This comment has been minimized.

Copy link

commented May 26, 2017

Coverage Status

Changes Unknown when pulling 6f1b2f2 on glennpratt:extract-dynect-bin into ** on fog:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.