Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DigitalOcean] Added filtering capabilities to servers request. #3822

Merged
merged 2 commits into from Jan 25, 2016

Conversation

@rroa
Copy link
Contributor

commented Jan 15, 2016

#3777 in the same way images were updated to support filtering, here's the same update for servers.

@geemus

This comment has been minimized.

Copy link
Member

commented Jan 19, 2016

Could you update the method signature for the mock version also? If you can update the mock version to do the right thing there that would be even better, but the difference in signature is likely to cause problems, so at least fixing that would be good. Thanks!

@rroa

This comment has been minimized.

Copy link
Contributor Author

commented Jan 20, 2016

Sure, will do.

@rroa

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2016

@geemus I'm having trouble finding the mocks you're referring to. I don't have much experience with shindo, as I have two PR's waiting for a similar update could you point me on the right direction for this one?

I assumed it was at tests/digitalocean/requests/compute_v2/list_serversL:69 but wanted to make sure it was just doing something like tests('#list_servers(#{filters})')

@geemus

This comment has been minimized.

Copy link
Member

commented Jan 22, 2016

@rroa actually, I just meant in the request definitions (I think the tests should be fine). In particular in the request files, there should be two defined methods (a real version and a mock version). So the method signature I was referring to updating, in this case, would be here: https://github.com/rroa/fog/blob/bugfix/do_servers_filters/lib/fog/digitalocean/requests/compute_v2/list_servers.rb#L16

Hope that clarifies, but just let me know if you have further questions or concerns. Thanks!

@rroa

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2016

@geemus Thanks for the help. I have updated the signature at the Mock to match the new changes.

@geemus

This comment has been minimized.

Copy link
Member

commented Jan 25, 2016

Great, thanks!

geemus added a commit that referenced this pull request Jan 25, 2016
Merge pull request #3822 from rroa/bugfix/do_servers_filters
[DigitalOcean] Added filtering capabilities to servers request.

@geemus geemus merged commit b6f8420 into fog:master Jan 25, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@coveralls

This comment has been minimized.

Copy link

commented Jan 3, 2018

Coverage Status

Changes Unknown when pulling 1eda931 on rroa:bugfix/do_servers_filters into ** on fog:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.