Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[DigitalOcean] Added filtering capabilities to servers request. #3822
@geemus I'm having trouble finding the mocks you're referring to. I don't have much experience with shindo, as I have two PR's waiting for a similar update could you point me on the right direction for this one?
I assumed it was at tests/digitalocean/requests/compute_v2/list_serversL:69 but wanted to make sure it was just doing something like
@rroa actually, I just meant in the request definitions (I think the tests should be fine). In particular in the request files, there should be two defined methods (a real version and a mock version). So the method signature I was referring to updating, in this case, would be here: https://github.com/rroa/fog/blob/bugfix/do_servers_filters/lib/fog/digitalocean/requests/compute_v2/list_servers.rb#L16
Hope that clarifies, but just let me know if you have further questions or concerns. Thanks!