Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internet_archive #3948

Merged
merged 6 commits into from Mar 20, 2017

Conversation

@icco
Copy link
Member

commented Mar 8, 2017

For #3942, dependent on https://github.com/fog/fog-internet-archive being working.

@icco icco requested a review from geemus Mar 8, 2017

@icco icco referenced this pull request Mar 8, 2017
@icco

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2017

This should be ready to go @geemus

@icco

This comment has been minimized.

Copy link
Member Author

commented Mar 12, 2017

Or maybe not...

@geemus

This comment has been minimized.

Copy link
Member

commented Mar 13, 2017

@icco looks like a couple more lingering weird things around bin still left, if you could fix those also that would be awesome. Thanks!

@icco icco force-pushed the icco/clean-internet-archive branch from a5541c8 to a28cef7 Mar 20, 2017

@icco

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2017

Ok @geemus, looks fixed.

@geemus
geemus approved these changes Mar 20, 2017
Copy link
Member

left a comment

LGTM, thanks!

@geemus geemus merged commit 48c5523 into master Mar 20, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@geemus geemus deleted the icco/clean-internet-archive branch Mar 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.