Slicehost dns fixes #595

Merged
merged 12 commits into from Nov 8, 2011

2 participants

@patio11

Hiya guys,

The Slicehost DNS API was not working properly.

dns.zones returned a list of zones correctly. However, trying to get the records for a particular zone would return a list of records for all zones, because the Slicehost API returned "zone-id" but the Fog internals were matching against "zone_id". I did some minor tweakage to the parser to address this and, relatedly, squash a bug where "record-type" would not match "record-type".

I also fixed a doc bug in the Slicehost records request.

Apologies for the feature branch being a wee bit on the unclean side -- my git-fu is weak, so there's a lot of "Whoopsie, didn't want to actually do that" in there.

patio11 added some commits Nov 8, 2011
@patio11 patio11 Slicehost uses record-type and zone-id for their API, which messes wi…
…th Fog internals, so changing these to record_type and zone_id in the parser.
32ad91a
@patio11 patio11 Did this do anything? c0cd1f5
@patio11 patio11 Revert "Slicehost uses record-type and zone-id for their API, which m…
…esses with Fog internals, so changing these to record_type and zone_id in the parser."

This reverts commit 32ad91a.
693815b
@patio11 patio11 Not having the best of days with git. Revert the reversion of the com…
…mit that I really do want to make.

This reverts commit 693815b.
5e2e241
@patio11 patio11 Slicehost uses record-type and zone-id for their API, which messes wi…
…th Fog internals, so changing these to record_type and zone_id in the parser.
426815d
@patio11 patio11 Merge branch 'slicehost_dns_fixes' of github.com:patio11/fog into sli…
…cehost_dns_fixes
fa18aa3
@patio11 patio11 Do not touch .gitignore bea05e7
@patio11 patio11 Fixing Slicehost DNS so that a) tests pass b) token names map to what…
… Fog expects -- record_type not record-type, value not data, etc c) creation of new DNS records possible
efeee6f
@patio11 patio11 1) Fix so that getting a single record actually works. 2) zone.record…
…s currently returns all records in account, not just records for that zone. Add failing test (temporarily, assumes test account has existing zones for this to actually fail) + fix. 3) Add in data alias for record.value, just in case someone needs it, as Slicehost calls this data.
8c680f0
@patio11

Hiya guys,

I'm continuing to hack away on the Slicehost DNS stuff to support folks' efforts to use Fog to help migrate them off of it. It turns out that the DNS API had quite a few bugs in it. A short list would include "Inability to update records", "All records in an account showing as being under a single zone", etc.

I've beefed up the test suite a wee bit and squashed the bugs that were on my own critical path for this week. There are likely more. I'm uncertain as to how much extra work this warrants, as Slicehost has been acquired and everyone will migrate off of it within a month (after which point the API will be shut down), but needed these fixes in the DNS module at least to script up my own integration.

patio11 added some commits Nov 8, 2011
@patio11 patio11 Allow updates of DNS records. Updates on zones not supported yet. c8c4324
@patio11 patio11 Fixing parsing of zone.records.get(id) so that it parses a single rec…
…ord properly rather than attempting to parse a list of records improperly. Fixing tests to match this (expected) behavior rather than work-around the broken way.
21e8071
@patio11 patio11 Getting it so zone.records works as expected (loads all records, for …
…that zone only).
7d84f8d
@geemus
fog member

Awesome, definitely sad to see slicehost going away, but thanks so much for making it easier for everybody to migrate.

@geemus geemus merged commit dd2ba79 into fog:master Nov 8, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment