Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

make fog/cloudstack support "servers.create" style server CRUD #765

Closed
wants to merge 12 commits into from

6 participants

@mingjin

e.g. compute.servers.create(options)
compute.servers.get server_id
server.destroy

@bdorry
Collaborator

Feng, these changes limit the information available from the list virtual machines command and will break existing implementations because you are using parsers to alter the response.

I am all for adding models, but I am against adding parsers into the cloudstack space since the responses are already json formatted. I'd suggest making your models work without changing (and in the process limiting) the response format.

@geemus
Owner

@mingjin I'm with @bdorry on this. If there is json available I would much prefer that we just use that over adding parsers. If you have any questions on that feel free to let us know though and we'd be happy to help out in terms of getting this fixed up. Thanks!

@mingjin

Hi, @bdorry @geemus, we've updated the code according to your suggestion, could you help review them? Thanks

@geemus
Owner

@mingjin - sorry for the delay, not sure how this fell through the cracks.

@bdorry - could you check it out and see how this fits in (I realize due to the duration of time passed that it may make less sense and/or not work now). Thanks!

@geemus
Owner

@bdorry hey, any chance you could take a look at this? I know it has been a little while, but would be good to figure out if this is worth rebasing and trying to get it in. Thanks!

@geemus
Owner

@dm1try - could you review this? Thanks!

@dm1try

@geemus hey, CRUD for server was already implemented, surprising :).

Maybe a key_pair model worth something, but here we have some deprecated things like a connection and we don't have any tests.

@tokengeek
Owner

Original work is 2 years old, despite the recent reviews.

Closing since it is too stale in my view.

@tokengeek tokengeek closed this
@geemus
Owner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.