MODINVSTOR-624: Upgrade to Vert.x 4 (WIP) #546
Conversation
Moving .addAll from saveInstances to executeInBatch allows for better separation of concerns and more simple method signature.
|
I approve this pull request, it builds when using folio-org/raml-module-builder#789 |
# Conflicts: # src/test/java/org/folio/rest/api/ItemEffectiveLocationTest.java
|
Kudos, SonarCloud Quality Gate passed! |
|
I approve this pull request. |
|
Thx @hjiebsco .. But we need this approved first.. folio-org/okapi#1053 . Otherwise mod-inventory-storage will not be able to be enabled for a tenant anywhere. |
Is that because the upgrade to vert.x 4.0 (and a new version of RAML Module Builder) also changes the version of the Tenant API provided? |
|
@MikhailFokanov I thought @adamdickmeiss just suggested that this should not be merged until the Okapi work it is blocked on was completed, why has this been merged? |
|
We dissussed with @julianladisch and @skoczko that it should be merged on the meeting 30 mins ago. I waited for approval from @julianladisch. When I see it in email notifiaction, I merged it. I am sorry, that I missed the new comments by @adamdickmeiss and @marcjohnson-kint (posted less than 20 mins ago). |
That's ok, I wasn't blaming you, only trying to understand what happened to cause something to be merged when it shouldn't have been. |
See RMB upgrade to Vert.x 4: folio-org/raml-module-builder#789
This is not intended to get built on Jenkins!
To test this pull request you need to build the RMB pull request above as 32.0.0-SNAPSHOT on your local machine and then build this mod-inventory-storage pull request branch.
This pull request is a temporary branch intended for testing the RMB upgrade.