Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow moduleVersionFrom with version only RMB-528 RMB-404 #576

Merged
merged 6 commits into from Dec 2, 2019
Merged

Allow moduleVersionFrom with version only RMB-528 RMB-404 #576

merged 6 commits into from Dec 2, 2019

Conversation

adamdickmeiss
Copy link
Contributor

Use Okapi's SemVer and ModuleId for dealing with module IDs and
semantic versions.

julianladisch
julianladisch approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@julianladisch julianladisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the RMB part of this.
I reject the Okapi part of this (OKAPI-777, OKAPI-781).

@adamdickmeiss
Copy link
Contributor Author

I'll see what I can do on OKAPI-781.

@adamdickmeiss adamdickmeiss merged commit c221121 into master Dec 2, 2019
@adamdickmeiss adamdickmeiss deleted the rmb-528-upgrade-version-messy branch December 2, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianladisch julianladisch julianladisch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@adamdickmeiss @julianladisch