Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to MirageJS #565

Merged
merged 8 commits into from Jul 17, 2020
Merged

Conversation

minkimcello
Copy link
Contributor

@minkimcello minkimcello commented Jul 15, 2020

Motivation

Screen Shot 2020-07-14 at 4 57 15 PM
This is part of an on-going initiative to completely migrate all of folio-org projects from @bigtest/mirage to miragejs.

@bigtest/mirage was originally a prototype to make mirage available to any framework, but it has since been archived in favor of miragejs. The documentation for miragejs is not only prodigious for its extensive API docs but also for its tutorials and guides. Furthermore, it receives regular bug-fixes and maintenance releases in thanks to its extremely large and active community.

Previous PR: @folio-org/ui-calendar #280
Linking the previous pull request so that subsequent ones can be found tagged below.

Overview of progress at the time of the creation of this PR (in chronological order):
ui-checkin
☑️ ui-checkout
☑️ ui-circulation
☑️ ui-calendar
☑️ ui-agreements

Approach

  • Cloned, installed, and then ran tests to double check that the tests are passing before refactoring.
  • Removed @bigtest/mirage and added inflected, faker, and miragejs as dev dependencies.
  • Configured miragejs as the server type for setupStripesCore().
  • Ran tests after the refactor to confirm they all pass.

@zburke zburke requested review from adi-mat and doytch July 17, 2020 19:57
@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@minkimcello minkimcello merged commit bd266dc into folio-org:master Jul 17, 2020
@minkimcello minkimcello deleted the mk/miragejs branch July 17, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants