Fixes getting path from woff files with CFF #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pomax
reviewed
May 30, 2019
test/glyphs.js
Outdated
| return assert.equal(glyph.name, 'T'); | ||
| }); | ||
| describe('WOFF otf glyphs', function() { | ||
| let font = fontkit.openSync(__dirname + '/data/SourceSansPro/SourceSansPro-Regular.otf.woff'); |
There was a problem hiding this comment.
I don't think there's a prettifier running for the source at the moment, but it looks like this got indented twice.
Pomax
reviewed
May 30, 2019
test/glyphs.js
Outdated
| describe('WOFF2 glyph', function() { | ||
| let font = fontkit.openSync(__dirname + '/data/SourceSansPro/SourceSansPro-Regular.woff2'); | ||
| describe('WOFF2 ttf glyph', function() { | ||
| let font = fontkit.openSync(__dirname + '/data/SourceSansPro/SourceSansPro-Regular.ttf.woff2'); |
There was a problem hiding this comment.
looks like there's double indentation here, too.
Pomax
reviewed
May 30, 2019
test/glyphs.js
Outdated
| }); | ||
|
|
||
| describe('WOFF2 otf glyph', function() { | ||
| let font = fontkit.openSync(__dirname + '/data/SourceSansPro/SourceSansPro-Regular.otf.woff2'); |
There was a problem hiding this comment.
looks like there's double indentation here, too
devongovett
force-pushed
the
fix-woff-cff
branch
from
03a31d5
to
9a9f0c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199
Uses stream from CFF table instead of font one which does not match in woff fonts