Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All integration tests failing #999

Open
jpravetz opened this issue Jul 16, 2019 · 2 comments

Comments

@jpravetz
Copy link

commented Jul 16, 2019

Bug Report

All integration tests failing. All unit tests are passing

Description of the problem

Clone and setup as per CONTRIBUTING.md instructions.
A range of diff errors including

  • binary stream differences,
  • PDF object numbers off by one (e. 18 0 R instead of 17 0 R)
  • xref table byte offsets off by 1 or 2 bytes

Your environment

  • pdfkit version: master 0.10.0
  • Node version: v12.6.0
  • Operating System: Mac
@blikblum

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2019

The integration tests were used mostly as regression testing when doing the recent large refactor. But is not very useful because every minor change leads to a massive diff, reason which would need to be updated regularly.

I plan to replace by visual regression testing that would not suffer with this problem

So, for now integration tests results should not be considered. All efforts should be done to add more unit tests

@jpravetz

This comment has been minimized.

Copy link
Author

commented Jul 16, 2019

I figured as much from the contributors notes, but wanted to confirm. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.