Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace deprecated String.prototype.substr() #196

Merged
merged 1 commit into from Mar 30, 2022
Merged

refactor: replace deprecated String.prototype.substr() #196

merged 1 commit into from Mar 30, 2022

Conversation

CommanderRoot
Copy link
Contributor

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
@RubenVerborgh RubenVerborgh self-requested a review March 30, 2022 13:39
@RubenVerborgh RubenVerborgh merged commit 79d0d8d into follow-redirects:main Mar 30, 2022
21 checks passed
@RubenVerborgh
Copy link
Collaborator

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants