From 326a90340ac6137a8fefdf6a1b4644169ab77fba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Vo=C5=99=C3=AD=C5=A1ek?= Date: Fri, 16 Dec 2022 15:26:27 +0100 Subject: [PATCH] drop Node 12 support --- .github/workflows/ci.yml | 2 +- package.json | 2 +- tasks/config/tasks.js | 15 ++++++--------- 3 files changed, 8 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8ec5c13a3d..5a6128c614 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,7 +20,7 @@ jobs: strategy: fail-fast: false matrix: - node-version: [12, 14, 16, 18, latest] + node-version: [14, 16, 18, latest] steps: - uses: actions/checkout@v3 - name: Setup Node.js ${{ matrix.node-version }} diff --git a/package.json b/package.json index 83abadd8a2..ae910ccf8f 100644 --- a/package.json +++ b/package.json @@ -86,7 +86,7 @@ "stylelint-config-standard": "^29.0.0" }, "engines": { - "node": ">=12", + "node": ">=14", "npm": ">=6.14.8" }, "title": "Fomantic UI", diff --git a/tasks/config/tasks.js b/tasks/config/tasks.js index a7bcc70932..89f0721147 100644 --- a/tasks/config/tasks.js +++ b/tasks/config/tasks.js @@ -17,12 +17,9 @@ let overrideBrowserslist = hasBrowserslistConfig ? undefined : [ 'android 4', ]; -// Node 12 does not support ??, so a little polyfill -let nullish = (value, fallback) => (value !== undefined && value !== null ? value : fallback); - module.exports = { - banner: nullish(config.banner, release.banner), + banner: config.banner ?? release.banner, log: { created: function (file) { @@ -95,11 +92,11 @@ module.exports = { /* Comment Banners */ header: { - year: nullish(config.header.year, new Date().getFullYear()), - title: nullish(config.header.title, release.title), - version: nullish(config.header.version, release.version), - repository: nullish(config.header.repository, release.repository), - url: nullish(config.header.url, release.url), + year: config.header.year ?? new Date().getFullYear(), + title: config.header.title ?? release.title, + version: config.header.version ?? release.version, + repository: config.header.repository ?? release.repository, + url: config.header.url ?? release.url, }, plumber: {