Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] Simplify less code #142

Merged
merged 2 commits into from Oct 1, 2018
Merged

[Button] Simplify less code #142

merged 2 commits into from Oct 1, 2018

Conversation

ColinFrick
Copy link
Member

Description

Currently the button.less has over 4600 lines of code, most of the code is need for the different colors which differ only in the used variables.
Simplifies:

  • color / primary / secondary
  • positive / negative

This doesn't change the built button.css except for:

  • Removed comment
  • Fixes typo in tertiary teal button (.ui.tertiarteal.buttons .tertiary.button)
  • Adds missing definition for secondary button margin left (primary was duplicated)
    .ui.buttons:not(.vertical) > .basic.primary.button:not(:first-child) {

Closes

#128

@ColinFrick ColinFrick added type/feat Any feature requests or improvements ⬇️ Low Priority lang/css Anything involving CSS labels Oct 1, 2018
@ColinFrick ColinFrick added the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 1, 2018
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really neat 👍

@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Oct 1, 2018
@y0hami y0hami merged commit 06f452c into fomantic:beta Oct 1, 2018
@y0hami y0hami mentioned this pull request Oct 2, 2018
@ColinFrick ColinFrick deleted the feat/128 branch October 22, 2018 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants