[Menu]: Fixes right dropdown sub-menu not being vertical #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This style was already added to the left menu
douglasg14b
changed the title
lubber-de
added
type/bug
lubber-de
added
the
state/awaiting-reviews
y0hami
removed
state/awaiting-reviews
y0hami
pushed a commit
that referenced
this pull request
May 9, 2019
The Fix of #632 was correctly implemented by the given jsfiddle. However in the PR itself the change was done differently (similiar to left menu...but this was also wrong already). Unfortunately the change now leads to break normal existing right menu elements This PR reverts the change by #632 but adds the fix out of the jsfiddle which was given by #632 ,so it' still @douglasg14b who found a fix for the main problem 😄
|
@all-contributors please add @douglasg14b for code and talk |
|
@hammy2899 I've put up a pull request to add @douglasg14b! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This style was already added to the left menu
Description
Fixes the issue where a right sub-menu dropdown of a menu would open up horizontally instead of vertically. This style was already added for the left menu, but was not for the right menu.
Testcase
https://jsfiddle.net/986c0o5L/1/
Closes
#382