Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown] Add possibility to add header items during js initialization #43

Merged
merged 1 commit into from Jul 4, 2018

Conversation

prudho
Copy link
Contributor

@prudho prudho commented Jun 28, 2018

Closes issue Semantic-Org/Semantic-UI#6420.

Allow to add header items to dropdown during js initialization, using this syntax:

$('.ui.dropdown').dropdown({
    values: [
      {
        name     : 'Filter by tag',
        type     : 'header'
        // Will be displayed as header
      },
      {
        name     : 'Important',
        value    : 'important',
        type     : 'item'
        // Will be displayed as item
      },
      {
        name     : 'Announcement',
        value    : 'announcement'
        // Will be displayed as item
      }
    ]
  });

Works too with API requests.

@prudho prudho added type/feat Any feature requests or improvements lang/javascript Anything involving JavaScript state/awaiting-reviews Pull requests which are waiting for reviews state/awaiting-docs Pull requests which need doc changes/additions labels Jun 28, 2018
@y0hami y0hami added Can Merge and removed state/awaiting-reviews Pull requests which are waiting for reviews labels Jun 29, 2018
@y0hami y0hami added state/awaiting-reviews Pull requests which are waiting for reviews and removed Can Merge labels Jul 4, 2018
@y0hami y0hami changed the base branch from next to beta July 4, 2018 10:05
@y0hami y0hami requested a review from ColinFrick July 4, 2018 13:19
@y0hami y0hami removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jul 4, 2018
@y0hami y0hami merged commit 83602a8 into fomantic:beta Jul 4, 2018
@prudho prudho deleted the enh-6420 branch July 5, 2018 04:58
@y0hami y0hami added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo type/feat Any feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants