New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for authentication #1170
Conversation
The failing test is due to a front end test being flaky. The back end tests all pass. |
This comment has been minimized.
This comment has been minimized.
@fonsp, you said that I could either disable auth and check that or verify auth with secret. I did the latter, because that is Pluto's default. Unfortunately, the commit I just pushed fails on two paths and I'm unsure whether this is meant to be or accidentally. With the logging (
Could you let me know what is the desired behaviour for these failing routes? I don't know enough about Pluto to make a good decision about this. |
My first reaction is to try removing the trailing slashes, i.e. Feel free to take a look, but I can also finish this myself! I think you want to add a small notebook to the session before testing the routes, see our other tests on how to do that. |
The sample URL should be URL-encoded. Open the Pluto main menu, go to samples and right click on one of the links to see what it looks like. (You can also use a running Pluto instance to take a look at the |
@fonsp, thanks for the feedback. I've applied most of it.
Could you pick this one up? I didn't figure it out and it's then probably quicker if you pick it up in a commit then we talking about it some more :) |
@rikhuijzer dankjewel! |
In #529, authentication was added. This PR adds some basic tests.
The benefit of these tests is that they are much easier to verify than the implementation in
src/webserver/Static.jl
.