Permalink
Commits on Aug 26, 2016
  1. @frank-trampe

    Merge pull request #2789 from jtanx/knife

    Make the knife tool cut at the tip. Fixes #2034
    frank-trampe committed on GitHub Aug 26, 2016
  2. @frank-trampe

    Merge pull request #2788 from jtanx/fill

    Show glyph outline when fill is on, preview off
    frank-trampe committed on GitHub Aug 26, 2016
  3. @jtanx
  4. @jtanx

    Show glyph outline when fill is on, preview off

    When fill mode is activated, show the outline. However,
    do not show the outline if preview mode is also activated.
    
    Fixes #2581
    jtanx committed Aug 26, 2016
Commits on Aug 23, 2016
  1. @frank-trampe

    Merge pull request #2784 from fontforge/resupport_relief_2

    Resupport fake relief for the toolbar and turn it off in the new theme.
    frank-trampe committed on GitHub Aug 23, 2016
  2. @frank-trampe

    Resupport fake relief for the toolbar and turn it off in the new theme.

    Conform types and add a comment about legacy fake relief support.
    frank-trampe committed Aug 22, 2016
  3. @jtanx

    Travis OSX: Fix path to formula (#2783)

    jtanx committed on GitHub Aug 23, 2016
Commits on Aug 22, 2016
  1. @frank-trampe

    Merge pull request #2773 from jtanx/ruler

    cvruler.c: Reenable the expose call for the ruler.
    frank-trampe committed on GitHub Aug 22, 2016
Commits on Aug 11, 2016
  1. @JoesCat

    Update po file so it can be edited. Resolves issue #2769 (#2772)

    This updates a ??.po file to meet the current FontForge build, by
    allowing a user to run make and specify which po file to upgrade.
    For this example, fr.po is specified:
    make FontForge-Update-po 1=fr
    JoesCat committed on GitHub Aug 11, 2016
  2. @jtanx

    cvruler.c: Reenable the expose call for the ruler.

    Without this call, the ruler information won't be updated as the ruler
    is used. I don't see the need to call GDrawProcessPendingEvents,
    and indeed, it works without this call. Calling GDrawRequestExpose
    will not cause an infinite stack recursion.
    
    Related to PR #1464 (Issues #1402 and #1458).
    jtanx committed Aug 11, 2016
Commits on Aug 8, 2016
  1. @jtanx

    Merge pull request #2767 from jrbastien/master

    Updated French translations
    jtanx committed on GitHub Aug 8, 2016
  2. @jrbastien

    Changed credits

    jrbastien committed Aug 8, 2016
  3. @jrbastien

    Added/corrected 400 translations. Mainly in the open/save/generate fo…

    …nts dialog boxes and the Preferences menu)
    jrbastien committed Aug 8, 2016
Commits on Aug 3, 2016
  1. @frank-trampe

    Merge pull request #2763 from dhull/fix-python-parsetupleandkeywords-…

    …calls
    
    Fix PyArg_ParseTupleAndKeywords calls.
    frank-trampe committed on GitHub Aug 3, 2016
  2. @frank-trampe

    Merge pull request #2760 from khaledhosny/python-creationtime

    Add font->creationtime
    frank-trampe committed on GitHub Aug 3, 2016
  3. @frank-trampe

    Merge pull request #2758 from jtanx/pecita

    splinesave.c: Ensure that hintmask is properly set for referenced chars
    frank-trampe committed on GitHub Aug 3, 2016
Commits on Aug 2, 2016
  1. Fix PyArg_ParseTupleAndKeywords calls.

    David Hull committed Jul 23, 2016
Commits on Jul 30, 2016
  1. @rrthomas
  2. @khaledhosny

    Add font->creationtime

    This uses the same format as UFO.
    khaledhosny committed Jul 30, 2016
Commits on Jul 28, 2016
  1. @jtanx

    Merge pull request #2759 from mvz/fix-bootstrap-instructions

    Tell people to run bootstrap first
    jtanx committed on GitHub Jul 28, 2016
  2. @mvz
Commits on Jul 27, 2016
  1. @jtanx

    splinesave.c: Ensure that hintmask is properly set for referenced chars

    Note: No need to check for autohinting (i.e. running SplineCharAutoHint)
    Because autohinting would have already been run on the base char if
    needed (in SplineChar2PS2), which would have autohinted ref chars.
    
    Related issue #1747
    jtanx committed Jul 27, 2016
  2. @frank-trampe

    Merge pull request #2756 from jtanx/pecita

    splinestroke.c: Fix buffer overrun in LineJoin
    frank-trampe committed on GitHub Jul 27, 2016
Commits on Jul 26, 2016
  1. @frank-trampe

    Merge pull request #2757 from serval2412/master

    Be sure "hv" is assigned in any case
    frank-trampe committed on GitHub Jul 26, 2016
Commits on Jul 25, 2016
  1. @serval2412

    Be sure "hv" is assigned in any case

    Indeed, if we're on !x_dir case, hv isn't assigned and so hv is slightly expected to be equalled to 2
    serval2412 committed Jul 25, 2016
  2. @serval2412 @jtanx

    cppcheck: fix "Suspicious condition and usage" (#2755)

    * cppcheck: fix "Suspicious condition and usage"
    
    [fontforge/dumppfa.c:2370]: (warning) Suspicious usage of 'sizeof' with a numeric constant as parameter.
    [gdraw/gtabset.c:408]: (warning) Suspicious usage of 'sizeof' with a numeric constant as parameter.
    [fontforge/stemdb.c:4619]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
    [fontforge/stemdb.c:4626]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
    [fontforge/svg.c:2046]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
    serval2412 committed with jtanx Jul 25, 2016
  3. @jtanx

    splinestroke.c: Fix buffer overrun in LineJoin

    Related issue: #1747
    jtanx committed Jul 25, 2016
Commits on Jul 24, 2016
  1. @jtanx

    Merge pull request #2754 from serval2412/master

    cppcheck: fix Redundant assignment
    jtanx committed on GitHub Jul 24, 2016
  2. @serval2412

    cppcheck: fix Redundant assignment

    [fontforgeexe/charinfo.c:4711]: (warning) Redundant assignment of 'vargcd[i][4].gd.popup_msg' to itself.
    + 1 similar case
    serval2412 committed Jul 24, 2016
Commits on Jul 23, 2016
  1. @JoesCat

    Copyrights concerning Issue 2643 and Issue 2732 (#2735)

    * bezctx_ff.c file based on bezctx_ps.c
    
    Debian lint highlighted some copyright questions.
    bezctx_ps.c from spiro-01 is GPL-2+
    Patches and mods below (approx) 10 lines are listed as contributions.
    
    * bezctx_ff.h file based on bezctx_ps.h
    
    Original bezctx_ps.h file is uncommented but is wrapped in GPL-2+ package.
    Adding authors is almost 50% of file contents, but it resolves issue 2643.
    
    * crctab.c is practically public domain
    
    Optimized versions using lookup tables exist in several text books,
    especially when demonstrating hardware, CPUs, and C/assembler code.
    
    * ofl.c and ofl.h created 2007-03-12
    
    George probably didn't want to copyright name to the file, or forgot to
    add it, but it's basically data files holding text information - which
    can then be used to make a SIL open source license.
    
    This patch resolves issue 2643 about author and file licence missing
    when run through debian lint.
    
    * ArabicForms.c created in 2001 - call it BSD-3-clause - issue #2643
    
    Debian Lint highlighted some copyright questions concerning this file.
    Since it's a "generated" file (created by another program), adding a
    copyright notice might appear a little odd and maybe not be worth the
    extra effort (when you come from a generation of programmers where
    computers had very little memory or drive storage space, so you had
    to put "extra" effort to save memory/storage space).
    Since the project was BSD-3-clause in 2001, seems logical to imply same.
    Patches and mods below (approx) 10 lines are listed as contributions.
    
    * utype.c, utype.h created in 2001 - call it BSD-3-clause - issue #2643
    
    Debian Lint highlighted some copyright questions concerning these files.
    Since they're "generated" files (created by another program), adding a
    copyright notice might appear a little odd and maybe not be worth the
    extra effort (when you come from a generation of programmers where
    computers had very little memory or drive storage space, so you had
    to put "extra" effort to save memory/storage space).
    Since the project was BSD-3-clause in 2001, seems logical to imply same.
    Patches and mods below (approx) 10 lines are listed as contributions.
    JoesCat committed on GitHub Jul 23, 2016
  2. @jtanx @JoesCat

    Static checker fixes (#2753)

    * gimageclut.c: Prevent use after free in GImageFindCLUT
    
    CID1357893
    
    Fixes use after free introduced by 36554a6
    gimage_reduceclut uses clutinf, so clutinf cannot be
    freed until after gimage_reduceclut has been called.
    
    * dumppfa.c: Prevent possible free of unitialised value
    
    CID1357892
    
    Introduced by ce47a52
    
    Where PSCharsFree is called, subrs may not have been
    alloc'ed. Setting subrs to NULL initially fixes this.
    
    * scripting.c: Fix resource leaks
    
    CID1357890, CID1357889, CID1357888
    
    * scripting.c: Add mising break statements in bSetTeXParams
    
    CID1357885, CID1357884, CID1357883
    
    * mmdlg.c Fix intended meaning of condition check
    
    CID1357881
    
    Presumably want to stop if pt is equal to either
    of ']' or '\0'
    
    * sfd.c: Reorder `adjust` allocation in SFDReadDeviceTable
    
    CID1357879, CID1357878
    
    This was introduced by f31f849
    
    In SFDReadDeviceTable, if `adjust` is not NULL, then
    `adjust` should not be freed. Reordering the allocation
    to after the condition check against `len` prevents a
    bad free from occurring.
    
    * fontview.c: Simplify logic in FVMenuCollabStart
    
    CID1309124, CID1083655
    
    gwwv_ask_string returns a copied buffer that the user must
    free. Furthermore, there is no point copying the same
    value back into `address`. Therefore, use `res` directly
    in the relevant areas and ensure that it is freed.
    
    * fontforge-internal-collab-server.c: Ensure NULL termination of ba.username
    
    CID1309123
    jtanx committed with JoesCat Jul 23, 2016
Commits on Jul 22, 2016
  1. @adrientetar

    Merge pull request #2749 from mungre/issue2748

    Zero pfminfo structure to fix FNT file metrics, closes #2748
    adrientetar committed on GitHub Jul 22, 2016
Commits on Jul 21, 2016
  1. Zero pfminfo structure to fix FNT file metrics, closes #2748

    The _FntFontDump function uses the SFDefaultOS2Info function to populate
    a pfminfo structure with font metrics that are written to the FNT file.
    
    The SFDefaultOS2Info function requires the pfminfo structure to be zeroed
    otherwise it can produce bogus values for a few metrics including linegap,
    which is used to calculate the external leading.
    
    This fix zeroes the structure.  It also fixes the problem for FON files
    because they are made of FNT files.
    
    I made the same fix in scripting.c.  I don't know that this was causing
    any problem.
    Charles Reilly committed Jul 21, 2016
  2. @jtanx

    Merge pull request #2742 from mungre/issue2741

    Write device name as empty string in FON file header, issue #2741
    jtanx committed on GitHub Jul 21, 2016
  3. @jtanx

    Merge pull request #2745 from jtanx/travis

    Travis OS X
    jtanx committed on GitHub Jul 21, 2016