New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the direction of the copyright-string null test in bitmap save #1143

Merged
merged 1 commit into from Jan 26, 2014

Conversation

Projects
None yet
1 participant
@mskala
Member

mskala commented Jan 26, 2014

When saving a BDF file, we thoughtfully test whether the copyright string is null, and if it is null, we pass it into strchr, causing a segmentation fault. This is, of course, backwards. It should only be dereferenced when not null.

mskala added a commit that referenced this pull request Jan 26, 2014

Merge pull request #1143 from mskala/inverted_copyright_test
correct the direction of the copyright-string null test in bitmap save

@mskala mskala merged commit 83f4bf9 into fontforge:master Jan 26, 2014

@mskala mskala deleted the mskala:inverted_copyright_test branch Jan 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment